-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/api: add an API to configure failpoints in runtime (#3488) #3809
Conversation
Signed-off-by: Yilin Chen <sticnarf@gmail.com> Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3809 +/- ##
===============================================
- Coverage 77.16% 74.66% -2.51%
===============================================
Files 204 211 +7
Lines 21940 19940 -2000
===============================================
- Hits 16931 14888 -2043
+ Misses 3724 3715 -9
- Partials 1285 1337 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1af22a4
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
1 similar comment
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What is changed and how it works?
Cherry pick #3488. Some integration tests depend on setting failpoints at runtime. We need this feature on release-4.0 to do integrations tests for 4.0.x.
Check List
Tests
First set
GO_FAILPOINTS="github.com/tikv/pd/server/api/enableFailpointAPI=return"
environment variable to enable this API.Then, we can run HTTP requests like this to set failpoints:
And we can also get the enabled failpoint list:
Code changes
Release note