-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schedulers]: get stores only once #4003
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
04e8a10
to
6ee5fb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4003 +/- ##
==========================================
- Coverage 74.61% 74.49% -0.12%
==========================================
Files 254 255 +1
Lines 25826 25831 +5
==========================================
- Hits 19269 19243 -26
- Misses 4847 4867 +20
- Partials 1710 1721 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…o feature/getStoresOnce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Please fix the test |
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: eab1ff5
|
Signed-off-by: bufferflies 1045931706@qq.com
What problem does this PR solve?
related #3744, Get stores only once to reduce scheduler execute time
What is changed and how it works?
stores should get once before schedule and it should input to plan
Check List
Tests
Code changes
Side effects
Related changes
Release note