Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: dynamically adjust the retry limit according to the operator #4007

Merged
merged 5 commits into from
Aug 27, 2021

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

related #3744

What is changed and how it works?

  • scheduler: dynamically adjust the retry limit according to the operator

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 19, 2021
@HunDunDM
Copy link
Member Author

/rebuild

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2021
@HunDunDM
Copy link
Member Author

/rebuild

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2021
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Aug 19, 2021
…or (tikv#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM
Copy link
Member Author

/rebuild

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #4007 (539618e) into master (c328f3a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
+ Coverage   74.49%   74.52%   +0.02%     
==========================================
  Files         257      257              
  Lines       25948    25980      +32     
==========================================
+ Hits        19331    19361      +30     
- Misses       4883     4886       +3     
+ Partials     1734     1733       -1     
Flag Coverage Δ
unittests 74.52% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/balance_leader.go 91.55% <100.00%> (+0.46%) ⬆️
server/schedulers/balance_region.go 88.59% <100.00%> (+0.52%) ⬆️
server/schedulers/utils.go 94.67% <100.00%> (+0.29%) ⬆️
server/schedule/region_scatterer.go 80.70% <0.00%> (-4.39%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/server.go 72.03% <0.00%> (-0.76%) ⬇️
server/tso/tso.go 58.56% <0.00%> (-0.56%) ⬇️
server/tso/allocator_manager.go 66.44% <0.00%> (-0.51%) ⬇️
server/schedule/operator/step.go 68.10% <0.00%> (-0.34%) ⬇️
client/client.go 71.54% <0.00%> (-0.28%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c328f3a...539618e. Read the comment docs.

Signed-off-by: HunDunDM <hundundm@gmail.com>
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 539618e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@ti-chi-bot ti-chi-bot merged commit fd3fc28 into tikv:master Aug 27, 2021
@HunDunDM HunDunDM deleted the dynamic-retry branch August 27, 2021 08:42
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Aug 27, 2021
…or (tikv#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>
zhouqiang-cl pushed a commit that referenced this pull request Aug 27, 2021
…or (#4007) (#4043)

* scheduler: dynamically adjust the retry limit according to the operator (#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Aug 29, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4046.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4047.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 29, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 29, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 29, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4048.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4049.

HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Aug 29, 2021
…or (tikv#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Aug 31, 2021
…or (tikv#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Sep 1, 2021
…or (#4007) (#4047)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Sep 3, 2021
…or (#4007) (#4049)

* scheduler: dynamically adjust the retry limit according to the operator (#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix pointer

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Sep 13, 2021
…or (#4007) (#4048)

* This is an automated cherry-pick of #4007

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: 混沌DM <hundundm@gmail.com>
HunDunDM added a commit that referenced this pull request Sep 27, 2021
…or (#4007)

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Oct 13, 2021
…or (#4007) (#4046)

* scheduler: dynamically adjust the retry limit according to the operator

Signed-off-by: HunDunDM <hundundm@gmail.com>

* address comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix license

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
v01dstar pushed a commit to v01dstar/pd that referenced this pull request Oct 28, 2021
…or (tikv#4007)

* scheduler: dynamically adjust the retry limit according to the operator

Signed-off-by: HunDunDM <hundundm@gmail.com>

* address comment

Signed-off-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants