api: add pprof zip api #4017

bufferflies · 2021-08-20T10:21:22Z

What problem does this PR solve?

relate: #4013

What is changed and how it works?

put pprof ,goroutine ,mutex,allocs,config,version to zip file

Check List

Tests

Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Need to cherry-pick to the release branch

Release note

add debug/zip http api to zip file that debug needed

Signed-off-by: bufferflies <1045931706@qq.com>

ti-chi-bot · 2021-08-20T10:21:23Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

disksing
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: bufferflies <1045931706@qq.com>

codecov · 2021-08-20T10:56:48Z

Codecov Report

Merging #4017 (addbf3e) into master (f4c20c9) will decrease coverage by 0.01%.
The diff coverage is 54.92%.

@@            Coverage Diff             @@
##           master    #4017      +/-   ##
==========================================
- Coverage   74.47%   74.45%   -0.02%     
==========================================
  Files         256      257       +1     
  Lines       25877    25948      +71     
==========================================
+ Hits        19272    19320      +48     
- Misses       4882     4894      +12     
- Partials     1723     1734      +11

Flag	Coverage Δ
unittests	`74.45% <54.92%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/api/version.go	`100.00% <ø> (ø)`
server/api/pprof.go	`54.28% <54.28%> (ø)`
server/api/router.go	`97.22% <100.00%> (+0.01%)`	⬆️
pkg/tempurl/tempurl.go	`45.00% <0.00%> (-15.00%)`	⬇️
server/schedule/operator/step.go	`68.10% <0.00%> (-1.67%)`	⬇️
server/grpc_service.go	`47.45% <0.00%> (-0.23%)`	⬇️
client/client.go	`71.82% <0.00%> (+0.13%)`	⬆️
server/tso/allocator_manager.go	`67.27% <0.00%> (+0.16%)`	⬆️
server/cluster/cluster.go	`82.58% <0.00%> (+0.35%)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c20c9...addbf3e. Read the comment docs.

nolouch

lgtm

Signed-off-by: bufferflies <1045931706@qq.com>

server/api/router.go

Signed-off-by: bufferflies <1045931706@qq.com>

…ture/pprofAll

server/api/router.go

Signed-off-by: bufferflies <1045931706@qq.com>

server/api/pprof.go

rleungx · 2021-08-23T04:50:59Z

server/api/pprof.go

+// @Produce application/octet-stream
+// @Router /pprof/debug/zip [get]
+func (h *ProfHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+	w.Header().Set("Content-Disposition", fmt.Sprintf(`attachment; filename="pd_debug"`+time.Now().Format("20060102_150405")+".zip"))


The format is a little bit different with TiDB.

yes, it will be better to splite date and time

I think we can let tidb with the new format.

server/api/pprof.go

Signed-off-by: bufferflies <1045931706@qq.com>

nolouch · 2021-08-27T04:38:03Z

/merge

ti-chi-bot · 2021-08-27T04:38:04Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-08-27T04:38:05Z

This pull request has been accepted and is ready to merge.

Commit hash: bba56e0

nolouch · 2021-08-27T05:51:31Z

/test

* add debug zip Signed-off-by: bufferflies <1045931706@qq.com> * change zip name and time format Signed-off-by: bufferflies <1045931706@qq.com> * import、annotation、log Signed-off-by: bufferflies <1045931706@qq.com> * pass ut Signed-off-by: bufferflies <1045931706@qq.com> * add unit test Signed-off-by: bufferflies <1045931706@qq.com> * pass ut Signed-off-by: bufferflies <1045931706@qq.com> * refine api route Signed-off-by: bufferflies <1045931706@qq.com> * pass ut Signed-off-by: bufferflies <1045931706@qq.com> * remove new prof handler Signed-off-by: bufferflies <1045931706@qq.com> * code lint Signed-off-by: bufferflies <1045931706@qq.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

bufferflies added 2 commits August 20, 2021 17:12

add debug zip

eeec548

Signed-off-by: bufferflies <1045931706@qq.com>

change zip name and time format

b0d7344

Signed-off-by: bufferflies <1045931706@qq.com>

ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 20, 2021

ti-chi-bot requested review from disksing and HunDunDM August 20, 2021 10:21

import、annotation、log

478af7e

Signed-off-by: bufferflies <1045931706@qq.com>

bufferflies changed the title ~~Feature/pprof all~~ api: add pprof zip api Aug 20, 2021

pass ut

4645aad

Signed-off-by: bufferflies <1045931706@qq.com>

nolouch approved these changes Aug 20, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021

bufferflies added 3 commits August 20, 2021 19:46

add unit test

d512bf8

Signed-off-by: bufferflies <1045931706@qq.com>

pass ut

6ab8b30

Signed-off-by: bufferflies <1045931706@qq.com>

Merge branch 'master' into feature/pprofAll

48672d2

disksing reviewed Aug 21, 2021

View reviewed changes

server/api/router.go Outdated Show resolved Hide resolved

bufferflies added 2 commits August 23, 2021 11:18

refine api route

7d73d85

Signed-off-by: bufferflies <1045931706@qq.com>

Merge branch 'feature/pprofAll' of github.com:bufferflies/pd into fea…

c2f2ec7

…ture/pprofAll

JmPotato reviewed Aug 23, 2021

View reviewed changes

server/api/router.go Outdated Show resolved Hide resolved

bufferflies added 2 commits August 23, 2021 11:49

pass ut

7d92428

Signed-off-by: bufferflies <1045931706@qq.com>

remove new prof handler

7286366

Signed-off-by: bufferflies <1045931706@qq.com>

disksing reviewed Aug 23, 2021

View reviewed changes

server/api/pprof.go Outdated Show resolved Hide resolved

disksing approved these changes Aug 23, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021

rleungx reviewed Aug 23, 2021

View reviewed changes

bufferflies and others added 2 commits August 23, 2021 14:11

code lint

6ab26f3

Signed-off-by: bufferflies <1045931706@qq.com>

Merge branch 'master' into feature/pprofAll

bba56e0

nolouch approved these changes Aug 27, 2021

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021

ti-chi-bot added 2 commits August 27, 2021 12:38

Merge branch 'master' into feature/pprofAll

b04e1f0

Merge branch 'master' into feature/pprofAll

f869b98

Merge branch 'master' into feature/pprofAll

addbf3e

ti-chi-bot merged commit c328f3a into tikv:master Aug 27, 2021

bufferflies deleted the feature/pprofAll branch February 17, 2022 06:30

kennytm mentioned this pull request Aug 28, 2024

Extend the debug/zip API to other tools (Lightning, Dumpling, BR) pingcap/tidb#55715

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: add pprof zip api #4017

api: add pprof zip api #4017

bufferflies commented Aug 20, 2021 •

edited by nolouch

Loading

ti-chi-bot commented Aug 20, 2021 •

edited

Loading

codecov bot commented Aug 20, 2021 •

edited

Loading

nolouch left a comment

rleungx Aug 23, 2021

bufferflies Aug 24, 2021

nolouch Aug 27, 2021

nolouch commented Aug 27, 2021

ti-chi-bot commented Aug 27, 2021

ti-chi-bot commented Aug 27, 2021

nolouch commented Aug 27, 2021

api: add pprof zip api #4017

api: add pprof zip api #4017

Conversation

bufferflies commented Aug 20, 2021 • edited by nolouch Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Aug 20, 2021 • edited Loading

codecov bot commented Aug 20, 2021 • edited Loading

Codecov Report

nolouch left a comment

Choose a reason for hiding this comment

rleungx Aug 23, 2021

Choose a reason for hiding this comment

bufferflies Aug 24, 2021

Choose a reason for hiding this comment

nolouch Aug 27, 2021

Choose a reason for hiding this comment

nolouch commented Aug 27, 2021

ti-chi-bot commented Aug 27, 2021

ti-chi-bot commented Aug 27, 2021

nolouch commented Aug 27, 2021

bufferflies commented Aug 20, 2021 •

edited by nolouch

Loading

ti-chi-bot commented Aug 20, 2021 •

edited

Loading

codecov bot commented Aug 20, 2021 •

edited

Loading