-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
labeler: add index to support rule override #4032
Conversation
Signed-off-by: disksing <i@disksing.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4032 +/- ##
==========================================
- Coverage 74.58% 74.54% -0.04%
==========================================
Files 256 256
Lines 25866 25877 +11
==========================================
- Hits 19293 19291 -2
- Misses 4859 4869 +10
- Partials 1714 1717 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 704d338
|
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Fix #4031
What is changed and how it works?
Add
Index
field toRegionLabelRule
. When multiple rules defines label with the same key, only the one with the maximum index takes effect. When there are multiple rules have an index equal to maximum value, the returned value is undefined behavior.Check List
Tests
Release note