Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedulers: evict-leader supports schedule the regions with unhealthy peers (#4096) #4130

Merged
merged 1 commit into from
Dec 3, 2021
Merged

schedulers: evict-leader supports schedule the regions with unhealthy peers (#4096) #4130

merged 1 commit into from
Dec 3, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4096

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

close #4093

What is changed and how it works?

schedulers: evict-leader supports schedule the regions with unhealthy peers

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

`evict-leader-scheduler` supports schedule the regions with unhealthy peers.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Sep 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2021
Merged
@ti-chi-bot ti-chi-bot added component/scheduler Scheduler logic. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. labels Sep 16, 2021
disksing
disksing reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need resolve conflict

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 30, 2021
@HunDunDM HunDunDM force-pushed the cherry-pick-4096-to-release-5.0 branch from 2d8d09d to 850b9f9 Compare December 1, 2021 07:40
@HunDunDM
schedulers: evict-leader supports schedule the regions with unhealthy…
0ab14f8 
… peers (tikv#4096)

close tikv#4093

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM force-pushed the cherry-pick-4096-to-release-5.0 branch from 850b9f9 to 0ab14f8 Compare December 1, 2021 07:47
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Dec 1, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0ab14f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Dec 1, 2021

/rebuild

@HunDunDM
Copy link
Member

HunDunDM commented Dec 2, 2021

/run-unit-test

1 similar comment
@JmPotato
Copy link
Member

JmPotato commented Dec 3, 2021

/run-unit-test

@HunDunDM
Copy link
Member

HunDunDM commented Dec 3, 2021

/run-unit-test

2 similar comments
@rleungx
Copy link
Member

rleungx commented Dec 3, 2021

/run-unit-test

@HunDunDM
Copy link
Member

HunDunDM commented Dec 3, 2021

/run-unit-test

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #4130 (0ab14f8) into release-5.0 (b940d5d) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #4130      +/-   ##
===============================================
- Coverage        74.95%   74.81%   -0.14%     
===============================================
  Files              245      245              
  Lines            24362    24370       +8     
===============================================
- Hits             18260    18233      -27     
- Misses            4493     4516      +23     
- Partials          1609     1621      +12
Flag Coverage Δ
unittests 74.81% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/evict_leader.go 75.36% <100.00%> (+0.99%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-5.89%) ⬇️
server/tso/allocator_manager.go 75.74% <0.00%> (-3.49%) ⬇️
server/member/member.go 66.84% <0.00%> (-3.27%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.58%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 65.99% <0.00%> (-1.22%) ⬇️
server/config/persist_options.go 91.43% <0.00%> (-0.78%) ⬇️
server/handler.go 41.97% <0.00%> (-0.50%) ⬇️
server/grpc_service.go 47.17% <0.00%> (-0.46%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b940d5d...0ab14f8. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 7161fde into tikv:release-5.0 Dec 3, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.6 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@disksing disksing disksing approved these changes

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees

@HunDunDM HunDunDM

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. triage/accept type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @HunDunDM @JmPotato @rleungx @disksing @nolouch @zhouqiang-cl