Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: evict-leader supports schedule the regions with unhealthy peers (#4096) #4131

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4096

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

close #4093

What is changed and how it works?

schedulers: evict-leader supports schedule the regions with unhealthy peers

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

`evict-leader-scheduler` supports schedule the regions with unhealthy peers.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 16, 2021
@ti-chi-bot ti-chi-bot added component/scheduler Scheduler logic. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick. labels Sep 16, 2021
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need resolve conflict

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 17, 2021
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6890087

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

/run-unit-tests

@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

/rebuild

@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

/run-unit-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #4131 (5bc2cc7) into release-5.1 (dcfbff7) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 5bc2cc7 differs from pull request most recent head 165f3a2. Consider uploading reports for the commit 165f3a2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.1    #4131      +/-   ##
===============================================
- Coverage        75.35%   75.27%   -0.09%     
===============================================
  Files              245      245              
  Lines            24686    24691       +5     
===============================================
- Hits             18602    18586      -16     
- Misses            4473     4489      +16     
- Partials          1611     1616       +5     
Flag Coverage Δ
unittests 75.27% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/evict_leader.go 75.48% <100.00%> (+1.10%) ⬆️
pkg/dashboard/adapter/manager.go 82.97% <0.00%> (-7.45%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-5.89%) ⬇️
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/tso/allocator_manager.go 78.13% <0.00%> (-2.84%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.58%) ⬇️
server/tso/tso.go 70.78% <0.00%> (-1.13%) ⬇️
server/cluster/coordinator.go 74.03% <0.00%> (-0.25%) ⬇️
client/client.go 71.82% <0.00%> (-0.14%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcab636...165f3a2. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

[FORMAT CHECKER NOTIFICATION]

Please provide the associated issue number in the commit messages, for example: close #12345, or ref #12345.

@nolouch nolouch merged commit 87081ee into tikv:release-5.1 Nov 30, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. do-not-merge/invalid-commit-message release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. triage/accept type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants