Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: evict-leader supports schedule the regions with unhealthy peers (#4096) #4132

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4096

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

close #4093

What is changed and how it works?

schedulers: evict-leader supports schedule the regions with unhealthy peers

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

`evict-leader-scheduler` supports schedule the regions with unhealthy peers.

… peers

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Sep 16, 2021
@ti-chi-bot ti-chi-bot added component/scheduler Scheduler logic. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. labels Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #4132 (07ad036) into release-5.2 (566cc53) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.2    #4132      +/-   ##
===============================================
+ Coverage        74.74%   74.77%   +0.03%     
===============================================
  Files              249      249              
  Lines            25620    25628       +8     
===============================================
+ Hits             19150    19164      +14     
+ Misses            4788     4784       -4     
+ Partials          1682     1680       -2     
Flag Coverage Δ
unittests 74.77% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/evict_leader.go 75.48% <100.00%> (+0.98%) ⬆️
server/kv/etcd_kv.go 72.46% <0.00%> (-7.25%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/election/leadership.go 83.90% <0.00%> (-3.45%) ⬇️
server/tso/tso.go 61.87% <0.00%> (-2.77%) ⬇️
server/schedule/operator_controller.go 83.56% <0.00%> (-1.19%) ⬇️
pkg/dashboard/adapter/manager.go 78.72% <0.00%> (-1.07%) ⬇️
server/schedule/operator/step.go 69.10% <0.00%> (-0.67%) ⬇️
server/cluster/cluster.go 82.81% <0.00%> (+0.47%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566cc53...07ad036. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Oct 13, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 82b77f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor

nolouch commented Oct 13, 2021

/run-unit-tests

1 similar comment
@nolouch
Copy link
Contributor

nolouch commented Oct 13, 2021

/run-unit-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants