Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: evict-leader supports schedule the regions with unhealthy peers (#4096) #4133

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4096

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

close #4093

What is changed and how it works?

schedulers: evict-leader supports schedule the regions with unhealthy peers

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

`evict-leader-scheduler` supports schedule the regions with unhealthy peers.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/scheduler Scheduler logic. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels Sep 16, 2021
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 22, 2021
@HunDunDM HunDunDM force-pushed the cherry-pick-4096-to-release-4.0 branch from 3f6a510 to bfe8dd1 Compare November 24, 2021 12:32
… peers tikv#4096

close tikv#4093

Signed-off-by: HunDunDM <hundundm@gmail.com>
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #4133 (ba98fc5) into release-4.0 (08bd389) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-4.0    #4133   +/-   ##
============================================
  Coverage        74.95%   74.95%           
============================================
  Files              211      211           
  Lines            20073    20081    +8     
============================================
+ Hits             15045    15052    +7     
- Misses            3697     3699    +2     
+ Partials          1331     1330    -1     
Flag Coverage Δ
unittests 74.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/evict_leader.go 75.00% <100.00%> (+1.00%) ⬆️
server/schedulers/random_merge.go 61.29% <0.00%> (-3.23%) ⬇️
server/member/leader.go 65.13% <0.00%> (-3.22%) ⬇️
pkg/etcdutil/etcdutil.go 72.05% <0.00%> (-2.95%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 87.03% <0.00%> (-1.86%) ⬇️
server/server.go 72.81% <0.00%> (-1.46%) ⬇️
server/grpc_service.go 59.07% <0.00%> (-1.21%) ⬇️
server/cluster/cluster.go 76.89% <0.00%> (-0.26%) ⬇️
pkg/dashboard/adapter/manager.go 85.10% <0.00%> (ø)
client/client.go 69.54% <0.00%> (+0.50%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bd389...ba98fc5. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2021
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 24, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 24, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ba98fc5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@ti-chi-bot ti-chi-bot merged commit b2c3de6 into tikv:release-4.0 Nov 24, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants