-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: speed scheduler exit (#4148) #4198
cluster: speed scheduler exit (#4148) #4198
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: bufferflies <1045931706@qq.com>
Codecov Report
@@ Coverage Diff @@
## release-5.1 #4198 +/- ##
===============================================
+ Coverage 75.14% 75.33% +0.19%
===============================================
Files 245 245
Lines 24682 24686 +4
===============================================
+ Hits 18547 18597 +50
+ Misses 4511 4478 -33
+ Partials 1624 1611 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6db04e8
|
[FORMAT CHECKER NOTIFICATION] Please provide the associated issue number in the commit messages, for example: |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #4148
What problem does this PR solve?
closed #4146 speed schedule exit
What is changed and how it works?
pause scheduler after accept stop signal, and do not loop
Check List
Tests
Code changes
Side effects
Related changes
Release note