-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: speed scheduler exit (#4148) #4200
cluster: speed scheduler exit (#4148) #4200
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need resolve conflict
Signed-off-by: bufferflies <1045931706@qq.com>
Codecov Report
@@ Coverage Diff @@
## release-4.0 #4200 +/- ##
===============================================
- Coverage 74.98% 74.97% -0.01%
===============================================
Files 211 211
Lines 20061 20065 +4
===============================================
+ Hits 15042 15043 +1
- Misses 3693 3697 +4
+ Partials 1326 1325 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@VelocityLight: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 96101b5
|
ref #4146 |
7021354
to
cd2d333
Compare
/merge |
@VelocityLight: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: cd2d333
|
This is an automated cherry-pick of #4148
What problem does this PR solve?
closed #4146 speed schedule exit
What is changed and how it works?
pause scheduler after accept stop signal, and do not loop
Check List
Tests
Code changes
Side effects
Related changes
Release note