core: use previous size if heartbeat's size is zero #4243

w41ter · 2021-10-28T03:08:54Z

ref tikv/tikv#11114

Signed-off-by: p4tr1ck patrick.li@pingcap.com

What problem does this PR solve?

Part of tikv/tikv#11114

close #4258

What is changed and how it works?

If region size is zero, try to use the previous size in origin region info.

Check List

Tests

Unit test

Code changes

none

Side effects

Increased code complexity
Breaking backward compatibility

Related changes

Release note

None

ti-chi-bot · 2021-10-28T03:08:55Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

rleungx · 2021-10-28T06:44:46Z

@PatrickNicholas CI failed.

w41ter · 2021-10-28T10:22:44Z

@PatrickNicholas CI failed.

fixed, PTAL

w41ter · 2021-10-29T02:14:24Z

/cc @lhy1024 @HunDunDM PTAL

ti-chi-bot · 2021-10-29T02:14:26Z

@PatrickNicholas: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lhy1024 @HunDunDM PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2021-10-29T02:43:48Z

Codecov Report

Merging #4243 (25da46d) into master (788f352) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
+ Coverage   74.80%   74.87%   +0.06%     
==========================================
  Files         264      264              
  Lines       27246    27253       +7     
==========================================
+ Hits        20382    20405      +23     
+ Misses       5043     5036       -7     
+ Partials     1821     1812       -9

Flag	Coverage Δ
unittests	`74.87% <100.00%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/cluster.go	`82.53% <100.00%> (+0.02%)`	⬆️
server/core/region.go	`91.81% <100.00%> (+0.09%)`	⬆️
pkg/errs/errs.go	`75.00% <0.00%> (-25.00%)`	⬇️
pkg/tempurl/tempurl.go	`45.00% <0.00%> (-15.00%)`	⬇️
server/schedule/operator_controller.go	`82.68% <0.00%> (-1.23%)`	⬇️
server/tso/allocator_manager.go	`65.50% <0.00%> (+0.33%)`	⬆️
server/grpc_service.go	`50.40% <0.00%> (+0.50%)`	⬆️
server/member/member.go	`66.84% <0.00%> (+0.53%)`	⬆️
server/tso/tso.go	`63.63% <0.00%> (+0.56%)`	⬆️
server/config/persist_options.go	`92.42% <0.00%> (+0.75%)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 788f352...25da46d. Read the comment docs.

lhy1024

This would be helpful in reducing redundant scheduling during reboots, but it would also make monitoring unintuitive.

w41ter · 2021-10-29T06:40:44Z

but it would also make monitoring unintuitive

Do you mean the monitoring of region size is not intuitive enough? TiKV server will update the region size asynchronously and report it to PD. This process is within 10 minutes and is related to the cluster size, the unintuitiveness intervals should be acceptable?

w41ter · 2021-10-29T06:44:09Z

/test

ref tikv/tikv#11114 Signed-off-by: p4tr1ck <patrick.li@pingcap.com>

rleungx

LGTM, except for @lhy1024 's comment

rleungx · 2021-11-01T05:42:34Z

/merge

ti-chi-bot · 2021-11-01T05:42:34Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-11-01T05:42:36Z

This pull request has been accepted and is ready to merge.

Commit hash: a9f3cb6

Signed-off-by: p4tr1ck <patrick.li@pingcap.com>

lhy1024 · 2021-11-01T06:29:09Z

/merge

ti-chi-bot · 2021-11-01T06:29:09Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-11-01T06:29:11Z

This pull request has been accepted and is ready to merge.

Commit hash: 8d69120

ti-chi-bot · 2021-11-01T06:29:21Z

@PatrickNicholas: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

* core: use previous size if heartbeat's size is zero ref tikv/tikv#11114 Signed-off-by: p4tr1ck <patrick.li@pingcap.com> * add issue link (tikv#4258) Signed-off-by: p4tr1ck <patrick.li@pingcap.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: hzh0425 <642256541@qq.com>

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message labels Oct 28, 2021

ti-chi-bot requested review from HunDunDM and lhy1024 October 28, 2021 03:09

w41ter mentioned this pull request Oct 28, 2021

raftstore: distinguish empty and size uninitialized region tikv/tikv#11170

Merged

w41ter force-pushed the support_zero_region_size branch from fc7f774 to 6874ff9 Compare October 28, 2021 10:20

w41ter closed this Oct 29, 2021

w41ter force-pushed the support_zero_region_size branch from 6874ff9 to 433d4f2 Compare October 29, 2021 06:09

w41ter reopened this Oct 29, 2021

lhy1024 reviewed Oct 29, 2021

View reviewed changes

w41ter force-pushed the support_zero_region_size branch from e0827b0 to c451858 Compare October 29, 2021 06:32

w41ter force-pushed the support_zero_region_size branch from c451858 to 38260e4 Compare November 1, 2021 02:15

core: use previous size if heartbeat's size is zero

a9f3cb6

ref tikv/tikv#11114 Signed-off-by: p4tr1ck <patrick.li@pingcap.com>

w41ter force-pushed the support_zero_region_size branch from 38260e4 to a9f3cb6 Compare November 1, 2021 02:22

rleungx approved these changes Nov 1, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2021

lhy1024 approved these changes Nov 1, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2021

ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. do-not-merge/invalid-commit-message labels Nov 1, 2021

add issue link (tikv#4258)

8d69120

Signed-off-by: p4tr1ck <patrick.li@pingcap.com>

w41ter force-pushed the support_zero_region_size branch from c087ad1 to 8d69120 Compare November 1, 2021 06:13

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021

Merge branch 'master' into support_zero_region_size

25da46d

ti-chi-bot merged commit e096598 into tikv:master Nov 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: use previous size if heartbeat's size is zero #4243

core: use previous size if heartbeat's size is zero #4243

w41ter commented Oct 28, 2021 •

edited

Loading

ti-chi-bot commented Oct 28, 2021 •

edited

Loading

rleungx commented Oct 28, 2021

w41ter commented Oct 28, 2021

w41ter commented Oct 29, 2021

ti-chi-bot commented Oct 29, 2021

codecov bot commented Oct 29, 2021 •

edited

Loading

lhy1024 left a comment

w41ter commented Oct 29, 2021

w41ter commented Oct 29, 2021

rleungx left a comment

rleungx commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

lhy1024 commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

core: use previous size if heartbeat's size is zero #4243

core: use previous size if heartbeat's size is zero #4243

Conversation

w41ter commented Oct 28, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Oct 28, 2021 • edited Loading

rleungx commented Oct 28, 2021

w41ter commented Oct 28, 2021

w41ter commented Oct 29, 2021

ti-chi-bot commented Oct 29, 2021

codecov bot commented Oct 29, 2021 • edited Loading

Codecov Report

lhy1024 left a comment

Choose a reason for hiding this comment

w41ter commented Oct 29, 2021

w41ter commented Oct 29, 2021

rleungx left a comment

Choose a reason for hiding this comment

rleungx commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

lhy1024 commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

ti-chi-bot commented Nov 1, 2021

w41ter commented Oct 28, 2021 •

edited

Loading

ti-chi-bot commented Oct 28, 2021 •

edited

Loading

codecov bot commented Oct 29, 2021 •

edited

Loading