Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix the help message of store limit #4274

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 3, 2021

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Close #4263.

What is changed and how it works?

Remove the incorrect parameter.

Check List

Tests

  • No code

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 3, 2021
@rleungx rleungx added the component/tools Tools. label Nov 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #4274 (da45914) into master (59ec446) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4274      +/-   ##
==========================================
- Coverage   74.91%   74.88%   -0.03%     
==========================================
  Files         264      264              
  Lines       27255    27255              
==========================================
- Hits        20418    20411       -7     
- Misses       5027     5034       +7     
  Partials     1810     1810              
Flag Coverage Δ
unittests 74.88% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/pd-ctl/pdctl/command/store_command.go 65.74% <100.00%> (ø)
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/tso/tso.go 60.22% <0.00%> (-4.55%) ⬇️
server/schedule/region_scatterer.go 80.70% <0.00%> (-4.39%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
server/tso/allocator_manager.go 65.16% <0.00%> (-1.00%) ⬇️
client/client.go 72.10% <0.00%> (-0.12%) ⬇️
server/grpc_service.go 50.40% <0.00%> (ø)
server/cluster/coordinator.go 75.10% <0.00%> (+0.42%) ⬆️
server/schedule/operator/step.go 73.06% <0.00%> (+0.73%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ec446...da45914. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 3, 2021
@rleungx
Copy link
Member Author

rleungx commented Nov 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e2ddcd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2021
@ti-chi-bot ti-chi-bot merged commit e5d7be1 into tikv:master Nov 3, 2021
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: hzh0425 <642256541@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tools Tools. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd-ctl help message for store limit is not suitable
4 participants