-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix the bug that region statistics are not updated after flow-round-by-digit change #4304
Conversation
…w-round-by-digit change close tikv#4295 Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4304 +/- ##
==========================================
+ Coverage 74.85% 74.89% +0.03%
==========================================
Files 264 264
Lines 27255 27257 +2
==========================================
+ Hits 20402 20413 +11
+ Misses 5036 5033 -3
+ Partials 1817 1811 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: HunDunDM <hundundm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 32652d7
|
In response to a cherrypick label: new pull request created: #4305. |
In response to a cherrypick label: new pull request created: #4306. |
…w-round-by-digit change (#4304) (#4305) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close #4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
In response to a cherrypick label: new pull request created: #4329. |
…w-round-by-digit change (tikv#4304) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close tikv#4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Signed-off-by: hzh0425 <642256541@qq.com>
…w-round-by-digit change (#4304) (#4329) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close #4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
…w-round-by-digit change (#4304) (#4306) * cluster: fix the bug that region statistics are not updated after flow-round-by-digit change close #4295 Signed-off-by: HunDunDM <hundundm@gmail.com> * refine some code Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
What problem does this PR solve?
fix #4295
What is changed and how it works?
A change in
flowRoundDivisor
also considers that the flow statistics have changed.Check List
Tests
Code changes
Side effects
Related changes
Release note