Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: check store status for running operators (#4223) #4367

Merged
merged 10 commits into from
Dec 1, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4223

What problem does this PR solve?

Fix #3353

What is changed and how it works?

  • For TransferLeader, AddLearner, AddPeer, check if the target store is down and cancel the operator if need.
  • Other types of OperatorStep may or may not get blocked by down store, we don't restrict them in the PR.
  • Add tests

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix the issue that operator can get blocked due to down store

close tikv#3353

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. labels Nov 23, 2021
Signed-off-by: disksing <i@disksing.com>
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 30, 2021
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 30, 2021
@disksing
Copy link
Contributor

disksing commented Dec 1, 2021

/run-all-tests

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #4367 (fa0de44) into release-5.0 (581ee38) will increase coverage by 0.12%.
The diff coverage is 62.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #4367      +/-   ##
===============================================
+ Coverage        74.76%   74.89%   +0.12%     
===============================================
  Files              245      245              
  Lines            24356    24370      +14     
===============================================
+ Hits             18210    18251      +41     
+ Misses            4522     4501      -21     
+ Partials          1624     1618       -6     
Flag Coverage Δ
unittests 74.89% <62.50%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/operator/step.go 68.45% <60.00%> (-0.20%) ⬇️
server/schedule/operator_controller.go 82.60% <100.00%> (ø)
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-2.36%) ⬇️
server/tso/global_allocator.go 71.01% <0.00%> (-1.45%) ⬇️
server/member/member.go 65.21% <0.00%> (-1.09%) ⬇️
server/grpc_service.go 46.60% <0.00%> (-0.57%) ⬇️
server/tso/tso.go 70.55% <0.00%> (+0.61%) ⬆️
server/encryptionkm/key_manager.go 73.60% <0.00%> (+0.79%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 581ee38...fa0de44. Read the comment docs.

@disksing disksing merged commit e482eed into tikv:release-5.0 Dec 1, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.6 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. triage/accept type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants