-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: check store status for running operators (#4223) #4368
operator: check store status for running operators (#4223) #4368
Conversation
close tikv#3353 Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c82c555
|
/run-all-tests |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: disksing <i@disksing.com>
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 468d2fd
|
/run-all-tests |
2 similar comments
/run-all-tests |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.1 #4368 +/- ##
===============================================
- Coverage 75.26% 75.10% -0.16%
===============================================
Files 245 245
Lines 24710 24724 +14
===============================================
- Hits 18598 18569 -29
- Misses 4492 4523 +31
- Partials 1620 1632 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is an automated cherry-pick of #4223
What problem does this PR solve?
Fix #3353
What is changed and how it works?
TransferLeader
,AddLearner
,AddPeer
, check if the target store is down and cancel the operator if need.OperatorStep
may or may not get blocked by down store, we don't restrict them in the PR.Check List
Tests
Related changes
Release note