Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: check store status for running operators (#4223) #4368

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4223

What problem does this PR solve?

Fix #3353

What is changed and how it works?

  • For TransferLeader, AddLearner, AddPeer, check if the target store is down and cancel the operator if need.
  • Other types of OperatorStep may or may not get blocked by down store, we don't restrict them in the PR.
  • Add tests

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix the issue that operator can get blocked due to down store

close tikv#3353

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2021
Signed-off-by: disksing <i@disksing.com>
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 30, 2021
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 30, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c82c555

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@disksing
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 468d2fd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@disksing
Copy link
Contributor

disksing commented Dec 1, 2021

/run-all-tests

2 similar comments
@disksing
Copy link
Contributor

disksing commented Dec 1, 2021

/run-all-tests

@disksing
Copy link
Contributor

disksing commented Dec 1, 2021

/run-all-tests

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #4368 (468d2fd) into release-5.1 (9615a4a) will decrease coverage by 0.15%.
The diff coverage is 62.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.1    #4368      +/-   ##
===============================================
- Coverage        75.26%   75.10%   -0.16%     
===============================================
  Files              245      245              
  Lines            24710    24724      +14     
===============================================
- Hits             18598    18569      -29     
- Misses            4492     4523      +31     
- Partials          1620     1632      +12     
Flag Coverage Δ
unittests 75.10% <62.50%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/operator/step.go 68.55% <60.00%> (+0.79%) ⬆️
server/schedule/operator_controller.go 85.51% <100.00%> (+0.40%) ⬆️
server/schedulers/shuffle_hot_region.go 55.10% <0.00%> (-10.21%) ⬇️
server/schedule/region_scatterer.go 81.61% <0.00%> (-4.49%) ⬇️
server/region_syncer/client.go 79.68% <0.00%> (-3.91%) ⬇️
server/member/member.go 65.59% <0.00%> (-3.23%) ⬇️
server/tso/allocator_manager.go 78.13% <0.00%> (-1.84%) ⬇️
server/tso/tso.go 70.78% <0.00%> (-1.69%) ⬇️
server/config/persist_options.go 91.50% <0.00%> (-0.78%) ⬇️
server/grpc_service.go 47.66% <0.00%> (-0.69%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9615a4a...468d2fd. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 8f64708 into tikv:release-5.1 Dec 1, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. triage/accept type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants