Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr-autosync: improve state file content (#4342) #4385

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4342

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

close #4341

What is changed and how it works?

  • use *time.Time instead of time.Time
  • add test
  • add some logs

Check List

Tests

  • Unit test

Code changes

  • Has persistent data change

Related changes

  • Need to cherry-pick to the release branch

Release note

Improve DR_STATE file content format

close tikv#4341

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. labels Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #4385 (9e2e793) into release-5.2 (6717f3f) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.2    #4385      +/-   ##
===============================================
- Coverage        74.84%   74.74%   -0.10%     
===============================================
  Files              249      249              
  Lines            25662    25672      +10     
===============================================
- Hits             19207    19189      -18     
- Misses            4770     4796      +26     
- Partials          1685     1687       +2     
Flag Coverage Δ
unittests 74.74% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/replication/replication_mode.go 79.60% <100.00%> (+0.84%) ⬆️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/region_syncer/server.go 82.96% <0.00%> (-5.93%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-2.33%) ⬇️
server/schedule/operator_controller.go 83.56% <0.00%> (-1.99%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/core/storage.go 68.44% <0.00%> (-0.77%) ⬇️
server/cluster/cluster.go 82.24% <0.00%> (-0.48%) ⬇️
server/server.go 72.63% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6717f3f...9e2e793. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 30, 2021
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 30, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9e2e793

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit 89c7cfd into tikv:release-5.2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. triage/accept type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants