-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dr-autosync: retry replicate state file #4403
Conversation
close tikv#4327 Signed-off-by: disksing <i@disksing.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4403 +/- ##
==========================================
+ Coverage 74.75% 74.84% +0.09%
==========================================
Files 264 264
Lines 27789 27796 +7
==========================================
+ Hits 20774 20805 +31
+ Misses 5151 5137 -14
+ Partials 1864 1854 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 778c9ba
|
* dr-autosync: retry replicate state file close tikv#4327 Signed-off-by: disksing <i@disksing.com> * fix ci Signed-off-by: disksing <i@disksing.com> * fix test Signed-off-by: disksing <i@disksing.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
close #4327
Besides the issue, if a member failed to persist state file, we will not retry.
What is changed and how it works?
Record members that are successfully replicated. During the tick process (default 1m interval), if it is found that not all members have fully updated their status, a retry will be performed.
Check List
Tests
Related changes
Release note