Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Rate limiter and audit #4470

Closed
wants to merge 13 commits into from

Conversation

CabinfeverB
Copy link
Member

@CabinfeverB CabinfeverB commented Dec 16, 2021

What problem does this PR solve?

This is a child PR of #4466
For details, please refer to #4466

NOTE: This PR will not merge.

What is changed and how it works?

implement ApiRateLimiter and AuditLogger

Check List

Tests

  • No code

Release note

None

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
… in last commit

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #4470 (e7ae2bf) into master (e7c795f) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   74.96%   74.74%   -0.22%     
==========================================
  Files         264      264              
  Lines       27796    27825      +29     
==========================================
- Hits        20837    20798      -39     
- Misses       5115     5170      +55     
- Partials     1844     1857      +13     
Flag Coverage Δ
unittests 74.74% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiutil/apiutil.go 36.61% <0.00%> (-25.29%) ⬇️
server/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/tso/tso.go 61.36% <0.00%> (-5.12%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/tso/allocator_manager.go 64.83% <0.00%> (-2.84%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/core/hot_region_storage.go 77.33% <0.00%> (-1.34%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/encryptionkm/key_manager.go 72.90% <0.00%> (-0.80%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c795f...e7ae2bf. Read the comment docs.

@CabinfeverB
Copy link
Member Author

close this PR to change spliting small PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants