-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api, pdctl: add HTTP Component signature #4491
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4491 +/- ##
==========================================
- Coverage 74.95% 74.83% -0.13%
==========================================
Files 264 264
Lines 27921 27933 +12
==========================================
- Hits 20929 20904 -25
- Misses 5127 5158 +31
- Partials 1865 1871 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. but ci failed.
b15265f
to
ed69b76
Compare
Co-authored-by: disksing <i@disksing.com> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Co-authored-by: disksing <i@disksing.com> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
ed69b76
to
9f916d6
Compare
/run-unit-test |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 34d403f
|
@CabinfeverB: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
close #4490 and related to #3111
This PR is going to support HTTP component signature
What is changed and how it works?
It adds a
RoundTripper
for adding a component signature header to every request and applies it to pdctl. (other components outside PD could add header by themselves)For the test, this PR creates a test server and registers a temp handler for
/pd/api/v1/health
(just for test) and sends the request by health pdctl cmd.Check List
Tests
Release note