statistic: replace old inherit with adopt in hot statistic #4512

lhy1024 · 2021-12-28T11:49:41Z

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

To close #4510

What is changed and how it works?

remove inherit in hot statistic
rename directly to inherit

Check List

Tests

Unit test

Release note

None.

ti-chi-bot · 2021-12-28T11:49:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HunDunDM
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2021-12-28T12:11:09Z

Codecov Report

Merging #4512 (3916382) into master (b140104) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4512      +/-   ##
==========================================
- Coverage   74.92%   74.81%   -0.12%     
==========================================
  Files         265      265              
  Lines       27865    27845      -20     
==========================================
- Hits        20877    20831      -46     
- Misses       5127     5150      +23     
- Partials     1861     1864       +3

Flag	Coverage Δ
unittests	`74.81% <100.00%> (-0.12%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/apiutil/serverapi/middleware.go	`69.69% <ø> (-0.90%)`	⬇️
server/statistics/kind.go	`34.37% <ø> (-1.99%)`	⬇️
server/statistics/hot_peer.go	`96.61% <100.00%> (ø)`
server/statistics/hot_peer_cache.go	`96.89% <100.00%> (+0.18%)`	⬆️
server/kv/etcd_kv.go	`69.56% <0.00%> (-10.15%)`	⬇️
server/schedulers/shuffle_hot_region.go	`55.55% <0.00%> (-10.11%)`	⬇️
server/tso/local_allocator.go	`64.86% <0.00%> (-6.76%)`	⬇️
server/tso/allocator_manager.go	`64.22% <0.00%> (-2.00%)`	⬇️
server/schedule/operator/step.go	`73.09% <0.00%> (-1.82%)`	⬇️
pkg/btree/btree.go	`85.78% <0.00%> (-0.97%)`	⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c4ff3...3916382. Read the comment docs.

rleungx · 2021-12-29T03:03:54Z

We may need some tests for this PR.

lhy1024 · 2021-12-29T07:42:40Z

We may need some tests for this PR.

yep, I will test it with regression tests

lhy1024 · 2022-01-04T09:31:10Z

We may need some tests for this PR.

yep, I will test it with regression tests

Its query is higher, and its stddev is less

ti-chi-bot · 2022-01-06T15:46:30Z

@lhy1024: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

server/statistics/kind.go

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2022-01-10T08:10:33Z

@nolouch PTAL

HunDunDM

LGTM, but can we add some tests that will fail before modification?

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2022-01-10T10:32:39Z

According to #4510, I add a test and it failed in master

lhy1024 · 2022-01-10T10:37:31Z

/merge

ti-chi-bot · 2022-01-10T10:37:31Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-01-10T10:37:33Z

This pull request has been accepted and is ready to merge.

Commit hash: 3916382

Signed-off-by: lhy1024 <admin@liudos.us>

… the interval is less than 60 (#4396) (#4433) * This is an automated cherry-pick of #4396 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix test Signed-off-by: lhy1024 <admin@liudos.us> * ref #4390 Signed-off-by: lhy1024 <admin@liudos.us> * fix ci Signed-off-by: lhy1024 <admin@liudos.us> * pick for #4446, #4512 Signed-off-by: lhy1024 <admin@liudos.us> * fix test Signed-off-by: lhy1024 <admin@liudos.us> * update Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

… the interval is less than 60 (#4396) (#4434) close #4390, ref #4396, ref #4446, ref #4512 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: 混沌DM <hundundm@gmail.com>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 28, 2021

ti-chi-bot requested review from rleungx and Yisaer December 28, 2021 11:49

rleungx added the component/statistics Statistics for scheduling. label Jan 6, 2022

rleungx approved these changes Jan 6, 2022

View reviewed changes

ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 6, 2022

nolouch reviewed Jan 10, 2022

View reviewed changes

server/statistics/kind.go Outdated Show resolved Hide resolved

remove inherit

e8ea238

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the remove-inherit branch from cfe0ec3 to e8ea238 Compare January 10, 2022 06:35

lhy1024 removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2022

lhy1024 changed the title ~~statistic: remove inherit in hot statistic~~ statistic: replace old inherit with adopt in hot statistic Jan 10, 2022

HunDunDM reviewed Jan 10, 2022

View reviewed changes

lhy1024 added 2 commits January 10, 2022 18:29

add test

9d4793c

Signed-off-by: lhy1024 <admin@liudos.us>

add test

3916382

Signed-off-by: lhy1024 <admin@liudos.us>

HunDunDM approved these changes Jan 10, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2022

ti-chi-bot merged commit 6f8edf2 into tikv:master Jan 10, 2022

lhy1024 mentioned this pull request Jan 21, 2022

statistics: fix the problem that the hot cache cannot be emptied when the interval is less than 60 (#4396) #4433

Merged

lhy1024 added a commit to lhy1024/pd that referenced this pull request Jan 21, 2022

pick for tikv#4446, tikv#4512

00a0290

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 added a commit to ti-chi-bot/pd that referenced this pull request Jan 21, 2022

pick for tikv#4446, tikv#4512

015d7c2

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 mentioned this pull request Jan 21, 2022

statistics: fix the problem that the hot cache cannot be emptied when the interval is less than 60 (#4396) #4434

Merged

lhy1024 added a commit to ti-chi-bot/pd that referenced this pull request Jan 21, 2022

pick for tikv#4446, tikv#4512

8bc6c00

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 mentioned this pull request Nov 10, 2022

scheduler: reduce memory used in median filter #5700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

statistic: replace old inherit with adopt in hot statistic #4512

statistic: replace old inherit with adopt in hot statistic #4512

lhy1024 commented Dec 28, 2021

ti-chi-bot commented Dec 28, 2021 •

edited

Loading

codecov bot commented Dec 28, 2021 •

edited

Loading

rleungx commented Dec 29, 2021

lhy1024 commented Dec 29, 2021

lhy1024 commented Jan 4, 2022

ti-chi-bot commented Jan 6, 2022

lhy1024 commented Jan 10, 2022

HunDunDM left a comment

lhy1024 commented Jan 10, 2022

lhy1024 commented Jan 10, 2022

ti-chi-bot commented Jan 10, 2022

ti-chi-bot commented Jan 10, 2022

statistic: replace old inherit with adopt in hot statistic #4512

statistic: replace old inherit with adopt in hot statistic #4512

Conversation

lhy1024 commented Dec 28, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 28, 2021 • edited Loading

codecov bot commented Dec 28, 2021 • edited Loading

Codecov Report

rleungx commented Dec 29, 2021

lhy1024 commented Dec 29, 2021

lhy1024 commented Jan 4, 2022

ti-chi-bot commented Jan 6, 2022

lhy1024 commented Jan 10, 2022

HunDunDM left a comment

Choose a reason for hiding this comment

lhy1024 commented Jan 10, 2022

lhy1024 commented Jan 10, 2022

ti-chi-bot commented Jan 10, 2022

ti-chi-bot commented Jan 10, 2022

ti-chi-bot commented Dec 28, 2021 •

edited

Loading

codecov bot commented Dec 28, 2021 •

edited

Loading