Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: simplify WaitUntil usage #4613

Merged
merged 2 commits into from
Jan 26, 2022
Merged

*: simplify WaitUntil usage #4613

merged 2 commits into from
Jan 26, 2022

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jan 26, 2022

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

There is always a C in the context, so we don't need the extra parameter.

What is changed and how it works?

Remove C from CheckFunc.

Check List

Tests

  • Unit test

Release note

None

ref tikv#4399

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022
Signed-off-by: disksing <i@disksing.com>
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #4613 (6f94e35) into master (4f5a78a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4613      +/-   ##
==========================================
- Coverage   74.75%   74.71%   -0.05%     
==========================================
  Files         281      281              
  Lines       27706    27706              
==========================================
- Hits        20713    20701      -12     
- Misses       5134     5137       +3     
- Partials     1859     1868       +9     
Flag Coverage Δ
unittests 74.71% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/testutil/testutil.go 94.11% <100.00%> (ø)
tests/cluster.go 82.97% <100.00%> (ø)
server/storage/endpoint/util.go 52.94% <0.00%> (-11.77%) ⬇️
server/storage/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
server/tso/tso.go 61.36% <0.00%> (-4.55%) ⬇️
server/region_syncer/server.go 81.45% <0.00%> (-3.98%) ⬇️
server/tso/allocator_manager.go 63.10% <0.00%> (-1.07%) ⬇️
server/server.go 73.11% <0.00%> (-0.99%) ⬇️
pkg/btree/btree.go 87.37% <0.00%> (-0.76%) ⬇️
server/cluster/cluster.go 83.98% <0.00%> (-0.54%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5a78a...6f94e35. Read the comment docs.

@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f94e35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@ti-chi-bot ti-chi-bot merged commit c1d1ecd into tikv:master Jan 26, 2022
@disksing disksing deleted the wait-until branch January 26, 2022 04:01
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 8, 2022
* *: simplify WaitUntil usage

ref tikv#4399

Signed-off-by: disksing <i@disksing.com>

* minor fix

Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants