-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: simplify WaitUntil usage #4613
Conversation
ref tikv#4399 Signed-off-by: disksing <i@disksing.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4613 +/- ##
==========================================
- Coverage 74.75% 74.71% -0.05%
==========================================
Files 281 281
Lines 27706 27706
==========================================
- Hits 20713 20701 -12
- Misses 5134 5137 +3
- Partials 1859 1868 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6f94e35
|
* *: simplify WaitUntil usage ref tikv#4399 Signed-off-by: disksing <i@disksing.com> * minor fix Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
There is always a
C
in the context, so we don't need the extra parameter.What is changed and how it works?
Remove
C
fromCheckFunc
.Check List
Tests
Release note