-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: support multi-k8s in grafana dashboards #4671
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: just1900 <legendj228@gmail.com>
57015a4
to
1256b2e
Compare
Could you add an issue link? and there must reference other components. |
Codecov Report
@@ Coverage Diff @@
## master #4671 +/- ##
==========================================
- Coverage 74.76% 74.74% -0.02%
==========================================
Files 284 284
Lines 27816 27816
==========================================
- Hits 20796 20791 -5
- Misses 5152 5154 +2
- Partials 1868 1871 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Do we have any test of this PR? |
I've added the tidb-operator issue link and PRs for other components into description.
Manual tested by load it to my grafana, it works fine. |
Signed-off-by: just1900 <legendj228@gmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c33512f
|
/run-cherry-picker |
In response to a cherrypick label: new pull request created: #4717. |
Signed-off-by: just1900 legendj228@gmail.com
What problem does this PR solve?
Issue Number: close #4673
K8s community and organizations are increasingly deploying multiple Kubernetes clusters to improve availability, isolation and scalability. Since TiDB Operator have support deploying tidb across-kubernetes, this PR will address the multi-k8s issue without affecting existing single-cluster use case.
What is changed and how it works?
What's Changed:
How it works:
kubernetes
label to identify k8s cluster in your prometheus'external_labels
.sed -i s/"hide": 2/"hide": 0/g <path/to/dashboard.json>
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note