Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: reformat load function to reduce code #4725

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 15, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: ref #4399

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 15, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 15, 2022

cc @AndreMouche

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #4725 (e534d0c) into master (c78c652) will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4725      +/-   ##
==========================================
+ Coverage   75.02%   75.06%   +0.04%     
==========================================
  Files         284      284              
  Lines       27985    27975      -10     
==========================================
+ Hits        20995    21000       +5     
+ Misses       5120     5108      -12     
+ Partials     1870     1867       -3     
Flag Coverage Δ
unittests 75.06% <83.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/endpoint/gc_safe_point.go 70.83% <50.00%> (+1.91%) ⬆️
server/storage/endpoint/config.go 76.47% <100.00%> (-2.48%) ⬇️
server/storage/endpoint/meta.go 62.35% <100.00%> (+1.43%) ⬆️
server/storage/endpoint/replication_status.go 63.63% <100.00%> (+9.79%) ⬆️
server/storage/endpoint/util.go 60.00% <100.00%> (-4.71%) ⬇️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/tso/tso.go 64.00% <0.00%> (-1.72%) ⬇️
server/cluster/cluster.go 84.37% <0.00%> (-0.55%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78c652...e534d0c. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e534d0c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot ti-chi-bot merged commit 5154c0b into tikv:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants