-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: pd can calculate the hot degree of the buckets. #4727
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
7599e80
to
d145071
Compare
Codecov Report
@@ Coverage Diff @@
## master #4727 +/- ##
==========================================
- Coverage 75.43% 75.36% -0.08%
==========================================
Files 303 306 +3
Lines 30015 30194 +179
==========================================
+ Hits 22643 22756 +113
- Misses 5386 5436 +50
- Partials 1986 2002 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4fe144d
to
5864e71
Compare
c3ffc6d
to
78c504a
Compare
4e624da
to
9b36a67
Compare
03018b1
to
c51a2af
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
c51a2af
to
ebc9704
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: bufferflies <1045931706@qq.com>
…eature/bucket-hot
1e314eb
to
1d555d3
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
50ff2f3
to
a5b0830
Compare
a5b0830
to
b3b0c8e
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
b3b0c8e
to
d68802f
Compare
/merge |
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d68802f
|
What problem does this PR solve?
Issue Number: Close #4726
What is changed and how it works?
using btree to store the map relation betweeen the key range and buckekItem.
using map to store the map relation between the region-id and bucketItem.
every bucket has own hotgree and inherits the highest degree of the overlaps.
suck like this:
origin buckets
|--10--|--20--|--30--|--40--|
|--2--|--3--|--4--|--5--|
after inheriting
|--10-|--30--|--35--|
|--3-|--3--|--4--|
Check List
Tests
Code changes
Side effects
Related changes
Release note