Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use old interface for scatter region (#4766) #4767

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4766

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: Close #4763

What is changed and how it works?

server: use old interface for scatter region

Check List

Tests

Release note

None

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-6.0 labels Mar 28, 2022
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 28, 2022
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tests/client/client_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 28, 2022
@nolouch
Copy link
Contributor

nolouch commented Mar 28, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c2057da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #4767 (c2057da) into release-6.0 (fa15ec2) will increase coverage by 0.04%.
The diff coverage is 50.00%.

@@               Coverage Diff               @@
##           release-6.0    #4767      +/-   ##
===============================================
+ Coverage        75.22%   75.26%   +0.04%     
===============================================
  Files              287      287              
  Lines            28163    28163              
===============================================
+ Hits             21185    21198      +13     
+ Misses            5112     5091      -21     
- Partials          1866     1874       +8     
Flag Coverage Δ
unittests 75.26% <50.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 52.46% <50.00%> (+0.74%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/tso/allocator_manager.go 67.02% <0.00%> (-2.32%) ⬇️
server/schedule/operator_controller.go 84.44% <0.00%> (-1.22%) ⬇️
pkg/btree/btree.go 87.37% <0.00%> (-0.76%) ⬇️
server/config/persist_options.go 92.88% <0.00%> (-0.75%) ⬇️
server/server.go 74.92% <0.00%> (-0.48%) ⬇️
server/member/member.go 66.84% <0.00%> (ø)
server/region_syncer/client.go 83.59% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa15ec2...c2057da. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 942b642 into tikv:release-6.0 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants