-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: implement for BucketStatInformer #4992
server: implement for BucketStatInformer #4992
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@bufferflies: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@bufferflies: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
033aa73
to
58cc16e
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
58cc16e
to
7334702
Compare
5d2f793
to
a700b16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Codecov Report
@@ Coverage Diff @@
## master #4992 +/- ##
==========================================
- Coverage 75.54% 75.42% -0.13%
==========================================
Files 306 307 +1
Lines 30194 30230 +36
==========================================
- Hits 22811 22800 -11
- Misses 5394 5431 +37
- Partials 1989 1999 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3413cab
to
6911897
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
6911897
to
615625b
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 431d7be
|
What problem does this PR solve?
Issue Number: Close #4991
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note