pdctl: verify pd address

cmd/pd-ctl/main.go

@@ -87,7 +87,9 @@ func loop() {
 			}
 			continue
 		}
-
+		if line == "exit" {
+			os.Exit(0)
+		}
 		args := strings.Split(strings.TrimSpace(line), " ")
 		args = append(args, "-u", url)
 		usage, err := pdctl.Start(args)

pdctl/command/global.go

@@ -26,7 +26,12 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var pdClient pd.Client
+var (
+	pdClient pd.Client
+
+	pingPrifix     = "pd/ping"
+	errInvalidAddr = errors.New("Invalid pd address, Cannot get connect to it")
+)
 
 // InitPDClient initialize pd client from cmd
 func InitPDClient(cmd *cobra.Command) error {
@@ -38,6 +43,10 @@ func InitPDClient(cmd *cobra.Command) error {
 	if pdClient != nil {
 		return nil
 	}
+	err = validPDAddr(addr)
+	if err != nil {
+		return err
+	}
 	pdClient, err = pd.NewClient([]string{addr})
 	if err != nil {
 		return err
@@ -75,6 +84,25 @@ func printResponseError(r *http.Response) {
 	io.Copy(os.Stdout, r.Body)
 }
 
+func validPDAddr(pd string) error {
+	u, err := url.Parse(pd)
+	if err != nil {
+		return err
+	}
+	if u.Scheme == "" {
+		u.Scheme = "http"
+	}
+	addr := u.String()
+	reps, err := http.Get(fmt.Sprintf("%s/%s", addr, pingPrifix))
+	if err != nil {
+		return err
+	}
+	if reps.StatusCode != http.StatusOK {
+		return errInvalidAddr
+	}
+	return nil
+}
+
 // UsageTemplate will used to generate a help information
 const UsageTemplate = `Usage:{{if .Runnable}}
   {{if .HasAvailableFlags}}{{appendIfNotPresent .UseLine ""}}{{else}}{{.UseLine}}{{end}}{{end}}{{if .HasAvailableSubCommands}}

pdctl/ctl.go

@@ -48,7 +48,10 @@ func Start(args []string) (string, error) {
 	rootCmd.SetArgs(args)
 	rootCmd.SilenceErrors = true
 	rootCmd.ParseFlags(args)
-	command.InitPDClient(rootCmd)
+	err := command.InitPDClient(rootCmd)
+	if err != nil {
+		return err.Error(), err
+	}
 	rootCmd.SetUsageTemplate(command.UsageTemplate)
 	if err := rootCmd.Execute(); err != nil {
 		return rootCmd.UsageString(), err