Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: clean some repeat code by use 1<<20 or 1<<30 #5308

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

bufferflies
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #5307

unit.KB= 1000
unitKiB= 1024

What is changed and how does it work?

Check List

Tests

Code changes

Side effects

Related changes

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #5308 (349f812) into master (05444e2) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
+ Coverage   75.72%   75.87%   +0.14%     
==========================================
  Files         312      312              
  Lines       30962    30962              
==========================================
+ Hits        23447    23493      +46     
+ Misses       5511     5475      -36     
+ Partials     2004     1994      -10     
Flag Coverage Δ
unittests 75.87% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mock/mockcluster/mockcluster.go 94.07% <100.00%> (ø)
server/core/region.go 91.27% <100.00%> (ø)
server/core/store.go 82.43% <100.00%> (ø)
server/core/test_util.go 83.20% <100.00%> (ø)
server/schedule/range_cluster.go 83.33% <100.00%> (ø)
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-6.90%) ⬇️
server/config/persist_options.go 93.37% <0.00%> (-0.70%) ⬇️
server/server.go 74.76% <0.00%> (-0.41%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05444e2...349f812. Read the comment docs.

Signed-off-by: bufferflies <1045931706@qq.com>
@rleungx rleungx changed the title server: clean some repeat code by use 1<<20 or 1<<30 server: clean some repeat code by use 1<<20 or 1<<30 Jul 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2022
@rleungx
Copy link
Member

rleungx commented Jul 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b450094

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@ti-chi-bot
Copy link
Member

@bufferflies: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f04b89e into tikv:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean some repeat code by use 1<<20 or 1<<30
4 participants