-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: clean some repeat code by use 1<<20
or 1<<30
#5308
Conversation
Signed-off-by: bufferflies <1045931706@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
1b71cde
to
8fbae90
Compare
Codecov Report
@@ Coverage Diff @@
## master #5308 +/- ##
==========================================
+ Coverage 75.72% 75.87% +0.14%
==========================================
Files 312 312
Lines 30962 30962
==========================================
+ Hits 23447 23493 +46
+ Misses 5511 5475 -36
+ Partials 2004 1994 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8fbae90
to
3f90c3a
Compare
Signed-off-by: bufferflies <1045931706@qq.com>
3f90c3a
to
b450094
Compare
1<<20
or 1<<30
1<<20
or 1<<30
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b450094
|
@bufferflies: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #5307
unit.KB= 1000
unitKiB= 1024
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note