*: put gRPC unknown error into the header. #5310

HuSharp · 2022-07-14T10:05:50Z

Signed-off-by: husharp jinhao.hu@pingcap.com

What problem does this PR solve?

Issue Number: Ref #5309. Close #5161

What is changed and how does it work?

put the unknown error into the header instead of directly returning a gRPC error.

Check List

Tests

Unit test

Release note

Put the unknown error into the header instead of directly returning a gRPC error.
And modify related uint tests and code.

ti-chi-bot · 2022-07-14T10:05:51Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Connor1996
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Connor1996

LGTM

server/grpc_service.go

server/grpc_service.go__failpoint_stash__

server/server.go__failpoint_stash__

server/util.go

server/grpc_service.go

JmPotato

server/grpc_service.go 100644 → 100755.

Please change the file access permission back.

codecov · 2022-07-15T08:59:38Z

Codecov Report

Merging #5310 (52314db) into master (3480a62) will increase coverage by 0.05%.
The diff coverage is 25.56%.

❗ Current head 52314db differs from pull request most recent head 0f8e815. Consider uploading reports for the commit 0f8e815 to get more accurate results

@@            Coverage Diff             @@
##           master    #5310      +/-   ##
==========================================
+ Coverage   75.69%   75.74%   +0.05%     
==========================================
  Files         312      312              
  Lines       31000    31043      +43     
==========================================
+ Hits        23464    23513      +49     
- Misses       5523     5528       +5     
+ Partials     2013     2002      -11

Flag	Coverage Δ
unittests	`75.74% <25.56%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/api/member.go	`52.38% <0.00%> (-0.85%)`	⬇️
server/tso/global_allocator.go	`61.25% <0.00%> (-1.32%)`	⬇️
server/grpc_service.go	`50.72% <19.31%> (-1.25%)`	⬇️
tests/cluster.go	`79.26% <25.00%> (-1.08%)`	⬇️
client/client.go	`69.52% <38.46%> (+0.90%)`	⬆️
client/base_client.go	`82.29% <100.00%> (+0.25%)`	⬆️
server/tso/allocator_manager.go	`63.18% <100.00%> (-1.71%)`	⬇️
pkg/tempurl/tempurl.go	`45.00% <0.00%> (-15.00%)`	⬇️
pkg/dashboard/adapter/redirector.go	`84.44% <0.00%> (-6.86%)`	⬇️
server/tso/tso.go	`69.49% <0.00%> (-3.39%)`	⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3480a62...0f8e815. Read the comment docs.

client/base_client.go

client/client.go

server/api/member.go

server/tso/allocator_manager.go

server/tso/global_allocator.go

tests/cluster.go

client/base_client.go

tools/pd-simulator/simulator/client.go

server/api/label_test.go

… gRPC error. Signed-off-by: husharp <jinhao.hu@pingcap.com>

JmPotato

The rest LGTM.

client/client.go

ti-chi-bot · 2022-07-21T12:24:46Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-21T12:24:47Z

This pull request has been accepted and is ready to merge.

Commit hash: 52314db

ti-chi-bot · 2022-07-21T12:25:00Z

@HuSharp: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ref #5310, ref #6069 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ref #5310, ref #6069, ref #6070 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>

close tikv#5161, ref tikv#5161 put the unknown error into the header instead of directly returning a gRPC error. Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

nolouch · 2023-06-30T05:50:21Z

/run-cherry-pick

ti-chi-bot · 2023-06-30T05:50:49Z

In response to a cherrypick label: new pull request created to branch release-6.5: #6727.

ti-chi-bot · 2023-06-30T05:50:49Z

In response to a cherrypick label: new pull request created to branch release-7.1: #6728.

close tikv#5161, ref tikv#5161 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

close #5161, ref #5309, ref #5310, ref pingcap/tiflash#7408 put the unknown error into the header instead of directly returning a gRPC error. Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: Hu# <jinhao.hu@pingcap.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 14, 2022

ti-chi-bot requested review from JmPotato and rleungx July 14, 2022 10:05

JmPotato requested a review from Connor1996 July 14, 2022 10:07

Connor1996 approved these changes Jul 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022

rleungx reviewed Jul 14, 2022

View reviewed changes

server/grpc_service.go Outdated Show resolved Hide resolved

HuSharp force-pushed the bugfix_grpc_error_return branch from 3975f1e to 3acccb5 Compare July 14, 2022 11:12

JmPotato reviewed Jul 14, 2022

View reviewed changes

HuSharp force-pushed the bugfix_grpc_error_return branch from 3acccb5 to 95eda28 Compare July 15, 2022 00:09

HuSharp changed the title ~~server: put gRPC unknown error into the header.~~ server/tso: put gRPC unknown error into the header. Jul 15, 2022

HuSharp force-pushed the bugfix_grpc_error_return branch from 95eda28 to bd1a75e Compare July 15, 2022 08:34

HuSharp changed the title ~~server/tso: put gRPC unknown error into the header.~~ *: put gRPC unknown error into the header. Jul 15, 2022

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 15, 2022

HuSharp force-pushed the bugfix_grpc_error_return branch from bd1a75e to e40eaf8 Compare July 15, 2022 08:51

HuSharp force-pushed the bugfix_grpc_error_return branch from e40eaf8 to bcaf870 Compare July 18, 2022 02:57

JmPotato requested review from rleungx and JmPotato July 18, 2022 03:07

JmPotato reviewed Jul 18, 2022

View reviewed changes

HuSharp force-pushed the bugfix_grpc_error_return branch 2 times, most recently from c75db57 to ffcb61a Compare July 19, 2022 09:22

JmPotato reviewed Jul 20, 2022

View reviewed changes

client/base_client.go Outdated Show resolved Hide resolved

tools/pd-simulator/simulator/client.go Outdated Show resolved Hide resolved

tools/pd-simulator/simulator/client.go Outdated Show resolved Hide resolved

JmPotato reviewed Jul 20, 2022

View reviewed changes

server/api/label_test.go Outdated Show resolved Hide resolved

put the unknown error into the header instead of directly returning a…

a578197

… gRPC error. Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the bugfix_grpc_error_return branch from ffcb61a to a578197 Compare July 20, 2022 08:38

JmPotato reviewed Jul 20, 2022

View reviewed changes

client/client.go Outdated Show resolved Hide resolved

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022

Merge branch 'master' into bugfix_grpc_error_return

0f8e815

ti-chi-bot merged commit bde0a1b into tikv:master Jul 21, 2022

HuSharp deleted the bugfix_grpc_error_return branch July 22, 2022 07:14

Defined2014 mentioned this pull request Jul 25, 2022

*: update pd-client to ensure tidb-server get clusterID correctly pingcap/tidb#36524

Merged

12 tasks

ti-srebot mentioned this pull request Jul 25, 2022

*: update pd-client to ensure tidb-server get clusterID correctly (#36524) pingcap/tidb#36539

Merged

12 tasks

zyguan mentioned this pull request Aug 8, 2022

tikv panic when run jepsen case jepsen-bank-tbls tikv/tikv#13124

Closed

JmPotato mentioned this pull request Aug 8, 2022

server: return GetMembers error as a gRPC error to let TiKV retry #5410

Closed

rleungx mentioned this pull request Mar 2, 2023

*: fix member race problem #6070

Merged

ti-chi-bot added a commit that referenced this pull request Mar 6, 2023

*: fix member race problem (#6070)

312e5b4

ref #5310, ref #6069 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Mar 6, 2023

*: fix member race problem (#6070) #6091

Merged

ti-chi-bot added a commit that referenced this pull request Mar 6, 2023

*: fix member race problem (#6070) (#6091)

51f382c

ref #5310, ref #6069, ref #6070 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>

zanmato1984 mentioned this pull request Jun 21, 2023

Store info in region cache won't be refreshed if tiflash nodes were ever scaled-in pingcap/tiflash#7408

Closed

nolouch mentioned this pull request Jun 30, 2023

*: put gRPC unknown error into the header. (#5310) #6724

Merged

nolouch added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 30, 2023

ti-chi-bot mentioned this pull request Jun 30, 2023

*: put gRPC unknown error into the header. (#5310) #6727

Closed

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 30, 2023

This is an automated cherry-pick of tikv#5310

1584544

close tikv#5161, ref tikv#5161 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 30, 2023

*: put gRPC unknown error into the header. (#5310) #6728

Closed

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 30, 2023

This is an automated cherry-pick of tikv#5310

e90eb02

close tikv#5161, ref tikv#5161 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

nolouch removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jun 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: put gRPC unknown error into the header. #5310

*: put gRPC unknown error into the header. #5310

HuSharp commented Jul 14, 2022 •

edited by JmPotato

Loading

ti-chi-bot commented Jul 14, 2022 •

edited

Loading

Connor1996 left a comment

JmPotato left a comment

codecov bot commented Jul 15, 2022 •

edited

Loading

JmPotato left a comment

ti-chi-bot commented Jul 21, 2022

ti-chi-bot commented Jul 21, 2022

ti-chi-bot commented Jul 21, 2022

nolouch commented Jun 30, 2023

ti-chi-bot commented Jun 30, 2023

ti-chi-bot commented Jun 30, 2023

*: put gRPC unknown error into the header. #5310

*: put gRPC unknown error into the header. #5310

Conversation

HuSharp commented Jul 14, 2022 • edited by JmPotato Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Jul 14, 2022 • edited Loading

Connor1996 left a comment

Choose a reason for hiding this comment

JmPotato left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 15, 2022 • edited Loading

Codecov Report

JmPotato left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Jul 21, 2022

ti-chi-bot commented Jul 21, 2022

ti-chi-bot commented Jul 21, 2022

nolouch commented Jun 30, 2023

ti-chi-bot commented Jun 30, 2023

ti-chi-bot commented Jun 30, 2023

HuSharp commented Jul 14, 2022 •

edited by JmPotato

Loading

ti-chi-bot commented Jul 14, 2022 •

edited

Loading

codecov bot commented Jul 15, 2022 •

edited

Loading