Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: speed up the balance-region-scheduler by decrease influence amp. (#5254) #5320

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5254

What problem does this PR solve?

Issue Number: Close #4990

What is changed and how does it work?

schedulers: speed up the balance-region-scheduler by decrease influence amp

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

100 TIKV simulator, 10GB region size:

current

operator:
image
region count:
image

master

image

4 TIKV, 1GB region size in real cluster:

current

image

region count:

image

master

image

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #5320 (a541f71) into release-6.1 (cf931ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a541f71 differs from pull request most recent head 680c1bc. Consider uploading reports for the commit 680c1bc to get more accurate results

@@             Coverage Diff              @@
##           release-6.1    #5320   +/-   ##
============================================
  Coverage        75.47%   75.47%           
============================================
  Files              307      307           
  Lines            30353    30354    +1     
============================================
+ Hits             22908    22910    +2     
  Misses            5452     5452           
+ Partials          1993     1992    -1     
Flag Coverage Δ
unittests 75.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/utils.go 94.02% <ø> (ø)
server/grpc_service.go 52.73% <100.00%> (+0.13%) ⬆️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/region_syncer/server.go 83.15% <0.00%> (-3.27%) ⬇️
server/tso/allocator_manager.go 60.56% <0.00%> (-2.00%) ⬇️
server/schedule/operator/step.go 74.07% <0.00%> (-1.02%) ⬇️
server/cluster/coordinator.go 70.63% <0.00%> (-0.83%) ⬇️
server/cluster/cluster.go 83.59% <0.00%> (-0.28%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061f671...680c1bc. Read the comment docs.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@nolouch
Copy link
Contributor

nolouch commented Jul 18, 2022

ptal @lhy1024

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a541f71

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@ti-chi-bot ti-chi-bot merged commit d32cfb9 into tikv:release-6.1 Jul 18, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants