Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TiDB Dashboard to v2022.07.27.1, ref #4257 (#5364) #5367

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5364

Signed-off-by: YiniXu9506 xuyini@pingcap.com

What problem does this PR solve?

Issue Number: Close #5366
Update TiDB Dashboard to v2022.07.27.1.

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch
    • 6.2

Release note

- Updates metrics query.
- Renames `metrics` to `monitoring` on TiDB Dashboard.

ref tikv#4257, close tikv#5366

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 27, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/visualization Visualization. require-LGT1 Indicates that the PR requires an LGTM. type/cherry-pick-for-release-6.2 labels Jul 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 27, 2022
@YiniXu9506
Copy link
Contributor

/cherry-pick-invite

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@nolouch
Copy link
Contributor

nolouch commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b699ef9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #5367 (b5e415f) into release-6.2 (c643f3f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-6.2    #5367      +/-   ##
===============================================
- Coverage        75.68%   75.66%   -0.02%     
===============================================
  Files              312      312              
  Lines            31060    31058       -2     
===============================================
- Hits             23508    23501       -7     
- Misses            5544     5550       +6     
+ Partials          2008     2007       -1     
Flag Coverage Δ
unittests 75.66% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 78.13% <ø> (-0.10%) ⬇️
server/replication/replication_mode.go 80.13% <100.00%> (ø)
server/region_syncer/server.go 81.86% <0.00%> (-5.50%) ⬇️
server/id/id.go 80.76% <0.00%> (-3.85%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-1.17%) ⬇️
server/schedulers/evict_leader.go 78.57% <0.00%> (-0.90%) ⬇️
server/schedule/operator_controller.go 85.74% <0.00%> (-0.81%) ⬇️
server/tso/tso.go 72.88% <0.00%> (-0.57%) ⬇️
server/tso/allocator_manager.go 64.51% <0.00%> (-0.50%) ⬇️
server/cluster/coordinator.go 71.00% <0.00%> (-0.38%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a2889...b5e415f. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit f56f03c into tikv:release-6.2 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/visualization Visualization. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants