Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: fix the wrong error handler. (#5374) #5377

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5374

Signed-off-by: bufferflies 1045931706@qq.com

What problem does this PR solve?

Issue Number: Close #5373

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

grpc: fix the wrong error handler 

bufferflies and others added 2 commits July 28, 2022 20:22
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved require-LGT1 Indicates that the PR requires an LGTM. type/cherry-pick-for-release-6.2 labels Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #5377 (18bc71e) into release-6.2 (f44b998) will decrease coverage by 0.11%.
The diff coverage is 55.55%.

❗ Current head 18bc71e differs from pull request most recent head 9452b9f. Consider uploading reports for the commit 9452b9f to get more accurate results

@@               Coverage Diff               @@
##           release-6.2    #5377      +/-   ##
===============================================
- Coverage        75.78%   75.66%   -0.12%     
===============================================
  Files              312      312              
  Lines            31058    31067       +9     
===============================================
- Hits             23536    23507      -29     
- Misses            5527     5552      +25     
- Partials          1995     2008      +13     
Flag Coverage Δ
unittests 75.66% <55.55%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 49.40% <55.55%> (-1.15%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
pkg/dashboard/adapter/manager.go 81.60% <0.00%> (-4.60%) ⬇️
server/id/id.go 80.76% <0.00%> (-3.85%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-3.10%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-2.24%) ⬇️
server/encryptionkm/key_manager.go 70.11% <0.00%> (-1.60%) ⬇️
server/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44b998...9452b9f. Read the comment docs.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022
@nolouch
Copy link
Contributor

nolouch commented Jul 29, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 18bc71e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@ti-chi-bot ti-chi-bot merged commit 989134e into tikv:release-6.2 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants