Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl: fix Ctrl+D #570

Merged
merged 2 commits into from
Mar 14, 2017
Merged

pd-ctl: fix Ctrl+D #570

merged 2 commits into from
Mar 14, 2017

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Mar 14, 2017

fix Ctrl+D to exit
PTAL @siddontang @disksing @overvenus

@c4pt0r
Copy link
Contributor

c4pt0r commented Mar 14, 2017

LGTM

@@ -83,7 +84,7 @@ func loop() {
Prompt: "\033[31m»\033[0m ",
HistoryFile: "/tmp/readline.tmp",
InterruptPrompt: "^C",
EOFPrompt: "exit",
EOFPrompt: "^D",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we still use exit now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still work.

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang siddontang merged commit f2d781e into master Mar 14, 2017
@siddontang siddontang deleted the shuning/fix-exit branch March 14, 2017 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants