Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: introduce base class of hot region scheduler #5708

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 15, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Ref #5691

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 15, 2022
@lhy1024 lhy1024 added component/scheduler Scheduler logic. type/refactor The issue belongs to a refactor work. labels Nov 15, 2022
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 75.65% // Head: 75.69% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (d76d994) compared to base (7a040fd).
Patch coverage: 98.76% of modified lines in pull request are covered.

❗ Current head d76d994 differs from pull request most recent head af96d18. Consider uploading reports for the commit af96d18 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5708      +/-   ##
==========================================
+ Coverage   75.65%   75.69%   +0.04%     
==========================================
  Files         329      329              
  Lines       32689    32654      -35     
==========================================
- Hits        24730    24718      -12     
+ Misses       5817     5808       -9     
+ Partials     2142     2128      -14     
Flag Coverage Δ
unittests 75.69% <98.76%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 84.93% <98.48%> (-0.11%) ⬇️
server/schedulers/grant_hot_region.go 53.97% <100.00%> (-4.70%) ⬇️
server/schedulers/shuffle_hot_region.go 55.12% <100.00%> (-10.88%) ⬇️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/id/id.go 83.05% <0.00%> (-10.17%) ⬇️
server/region_syncer/server.go 82.96% <0.00%> (-4.40%) ⬇️
server/member/member.go 62.10% <0.00%> (-3.69%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch nolouch requested review from HunDunDM and removed request for nolouch November 17, 2022 12:57
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2022
@nolouch
Copy link
Contributor

nolouch commented Nov 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d76d994

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ff29b53 into tikv:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants