-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: update Go version, wording #5777
Conversation
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@Oreoxmt: GitHub didn't allow me to request PR reviews from the following users: lilin90. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lilin90: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: dc66545
|
Codecov ReportBase: 75.65% // Head: 75.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5777 +/- ##
=======================================
Coverage 75.65% 75.65%
=======================================
Files 329 329
Lines 32961 32961
=======================================
+ Hits 24936 24937 +1
+ Misses 5883 5877 -6
- Partials 2142 2147 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Aolin aolin.zhang@pingcap.com
What problem does this PR solve?
Issue Number: Close #5776
What is changed and how does it work?
Check List
Tests
Related changes
pingcap/docs
/pingcap/docs-cn
: update go to v1.19 pingcap/docs-cn#12280Release note