Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics/grafana: fix Error showing "Current ID assignment" #5899

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Feb 2, 2023

Signed-off-by: husharp jinhao.hu@pingcap.com

What problem does this PR solve?

Issue Number: Close #5898

What is changed and how does it work?

The old version of idalloc is a globally unique path, and keyspace needs to use id allocator to allocate keyspaceID, so in this pr the id allocator is changed to a general purpose, but not sync metrics.
https://github.com/tikv/pd/pull/5284

image

Release note

None

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 2, 2023
@ti-chi-bot ti-chi-bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Feb 2, 2023
@ti-chi-bot
Copy link
Member

Hi @HuSharp. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp marked this pull request as ready for review February 2, 2023 05:11
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 75.54% // Head: 75.75% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (2f49e0f) compared to base (abb62d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5899      +/-   ##
==========================================
+ Coverage   75.54%   75.75%   +0.21%     
==========================================
  Files         343      343              
  Lines       34993    34993              
==========================================
+ Hits        26434    26509      +75     
+ Misses       6275     6228      -47     
+ Partials     2284     2256      -28     
Flag Coverage Δ
unittests 75.75% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-4.55%) ⬇️
pkg/utils/etcdutil/etcdutil.go 82.55% <0.00%> (-2.33%) ⬇️
server/api/region.go 68.09% <0.00%> (-1.43%) ⬇️
server/schedule/region_scatterer.go 77.86% <0.00%> (-1.19%) ⬇️
pkg/btree/btree_generic.go 86.34% <0.00%> (-0.93%) ⬇️
server/cluster/coordinator.go 71.59% <0.00%> (-0.76%) ⬇️
server/schedule/operator/step.go 76.76% <0.00%> (-0.69%) ⬇️
pkg/member/member.go 63.68% <0.00%> (-0.53%) ⬇️
server/cluster/cluster.go 81.76% <0.00%> (-0.43%) ⬇️
server/config/persist_options.go 92.83% <0.00%> (-0.33%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2023
@JmPotato
Copy link
Member

JmPotato commented Feb 2, 2023

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4490dab

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Feb 2, 2023

/test build

@ti-chi-bot
Copy link
Member

@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx
Copy link
Member

rleungx commented Feb 2, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 2, 2023
@ti-chi-bot ti-chi-bot merged commit 4189e94 into tikv:master Feb 2, 2023
@HuSharp HuSharp deleted the fix_id_alloc_grafana branch February 3, 2023 02:42
@ti-chi-bot
Copy link
Member

@JmPotato: failed to apply #5899 on top of branch "release-6.6":

failed to git commit: exit status 1

In response to this:

/cherry-pick release-6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato JmPotato added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 17, 2023
@JmPotato
Copy link
Member

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6016.

@ti-chi-bot
Copy link
Member

@JmPotato: new pull request could not be created: failed to create pull request against tikv/pd#release-6.5 from head ti-chi-bot:cherry-pick-5899-to-release-6.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5899-to-release-6.5."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit that referenced this pull request Feb 17, 2023
…6016)

close #5898, ref #5899

The old version of idalloc is a globally unique path, and keyspace needs to use id allocator to allocate keyspaceID, so in this pr the id allocator is changed to a general purpose, but not sync metrics.
#5284

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grafana: Error showing "Current ID assignment"
5 participants