-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: refactor server entry point to support multi-mode service #5921
Conversation
A service in different mode has different config struct and initialization logic, so we need to abstract an interface to create server. Signed-off-by: Bin Shi <binshi.bing@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @binshi-bing. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 75.44% // Head: 75.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5921 +/- ##
==========================================
- Coverage 75.44% 75.31% -0.14%
==========================================
Files 345 345
Lines 35126 35126
==========================================
- Hits 26501 26454 -47
- Misses 6325 6374 +49
+ Partials 2300 2298 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 58a7b1f
|
/rebuild |
/test build |
1 similar comment
/test build |
/ok-to-test |
@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Bin Shi binshi.bing@gmail.com
What problem does this PR solve?
Issue Number: Ref #5836
What is changed and how does it work?
A service in different mode has different config struct and initialization logic, so we need to abstract an interface to create server.
Check List
Tests
I did some compatibility test manually by verifying that the all-in-one pd-server can start normally w/o and w/ parameter.
Related changes
None.
Release note