Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enable_flaky_tests and skip some flaky tests in gctuner (#5975) #5977

Closed

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5975

Signed-off-by: Sen Han 00hnes@gmail.com

What problem does this PR solve?

Issue Number: ref #5953

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 13, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. type/cherry-pick-for-release-6.6 labels Feb 13, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 13, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 75.22% // Head: 75.06% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (90e8013) compared to base (2be26ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.6    #5977      +/-   ##
===============================================
- Coverage        75.22%   75.06%   -0.17%     
===============================================
  Files              362      362              
  Lines            36221    36221              
===============================================
- Hits             27247    27189      -58     
- Misses            6600     6652      +52     
- Partials          2374     2380       +6     
Flag Coverage Δ
unittests 75.06% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/gogc/gogc.go 9.09% <0.00%> (-54.55%) ⬇️
pkg/gctuner/memory_limit_tuner.go 46.66% <0.00%> (-42.23%) ⬇️
pkg/gctuner/finalizer.go 70.00% <0.00%> (-30.00%) ⬇️
server/api/diagnostic.go 76.92% <0.00%> (-23.08%) ⬇️
pkg/cgroup/cgroup_cpu_linux.go 22.22% <0.00%> (-16.67%) ⬇️
pkg/gctuner/tuner.go 60.00% <0.00%> (-12.00%) ⬇️
pkg/tso/local_allocator.go 68.91% <0.00%> (-6.76%) ⬇️
server/cluster/diagnostic_manager.go 72.04% <0.00%> (-4.31%) ⬇️
pkg/storage/storage.go 67.30% <0.00%> (-3.85%) ⬇️
pkg/tso/tso.go 71.34% <0.00%> (-3.38%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hnes
Copy link
Contributor

hnes commented Feb 14, 2023

Closed because this PR is not necessary for release-6.6.

@lhy1024 lhy1024 closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants