-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: no more redundant etcd writes when ReportMinResolvedTS
is called (#5966)
#5979
cluster: no more redundant etcd writes when ReportMinResolvedTS
is called (#5966)
#5979
Conversation
Signed-off-by: HunDunDM <hundundm@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.51% // Head: 75.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #5979 +/- ##
===============================================
+ Coverage 75.51% 75.61% +0.10%
===============================================
Files 330 330
Lines 32952 32951 -1
===============================================
+ Hits 24884 24917 +33
+ Misses 5911 5885 -26
+ Partials 2157 2149 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5ef0e32
|
This is an automated cherry-pick of #5966
Signed-off-by: HunDunDM hundundm@gmail.com
What problem does this PR solve?
Issue Number: Close #5965
What is changed and how does it work?
no more redundant etcd writes when
SetMinResolvedTS
is calledCheck List
Tests
putStoreLocked
called bySetMinResolvedTS
slower 7a47041tiup playground v6.5.0 --kv=15 --db=1 --pd=1 --tiflash=0 --pd.binpath=bin/pd-server
putStoreLocked
was removed in this PR and replaced withc.core.PutStore(newStore)
, so it can be considered fixed.Code changes
Side effects
Related changes
Release note