Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix unhealth region skip the rule check (#6427) #6463

Closed
wants to merge 2 commits into from
Closed

checker: fix unhealth region skip the rule check (#6427) #6463

wants to merge 2 commits into from

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 15, 2023

close #6426

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?


allow the `schedule=deny` label can do rule constraints check

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@nolouch @ti-chi-bot
checker: fix unhealth region skip the rule check (tikv#6427)
28d8fa7 
close tikv#6426

allow the `schedule=deny` label can do rule constraints check

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/cherry-pick-not-approved labels May 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx May 15, 2023 03:12
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2023
rleungx
rleungx reviewed May 15, 2023
View reviewed changes
server/cluster/coordinator.go Outdated
foundDisabled := false
for _, op := range ops {
if labelMgr := s.cluster.GetRegionLabeler(); labelMgr != nil {
if labelMgr.ScheduleDisabled(s.cluster.GetRegion(op.RegionID())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure the region not nil.

@nolouch
fix panic
66759f8 
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: +0.04 🎉

Comparison is base (da5a4e9) 74.70% compared to head (66759f8) 74.75%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-7.0    #6463      +/-   ##
===============================================
+ Coverage        74.70%   74.75%   +0.04%     
===============================================
  Files              394      394              
  Lines            38763    38770       +7     
===============================================
+ Hits             28959    28981      +22     
+ Misses            7266     7252      -14     
+ Partials          2538     2537       -1
Flag Coverage Δ
unittests 74.75% <88.23%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/schedule/operator_controller.go 85.64% <ø> (-0.42%) ⬇️
server/cluster/cluster.go 81.96% <ø> (ø)
server/cluster/coordinator.go 71.79% <81.81%> (+0.20%) ⬆️
pkg/schedule/checker/checker_controller.go 80.00% <100.00%> (+2.47%) ⬆️
pkg/schedule/metrics.go 100.00% <100.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch
Copy link
Contributor Author

nolouch commented May 15, 2023

it's only used to test.

@nolouch nolouch closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nolouch @lhy1024 @rleungx