Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: unify import path format and rename the store meta functions #6481

Merged
merged 1 commit into from
May 18, 2023
Merged

*: unify import path format and rename the store meta functions #6481

merged 1 commit into from
May 18, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 18, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Part of #6418.

Check List

Tests

  • Unit test

Release note

None.

@rleungx
unify import path format and rename the store meta functions
54e0152 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 18, 2023
@rleungx rleungx changed the title unify import path format and rename the store meta functions *: unify import path format and rename the store meta functions May 18, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch May 18, 2023 05:16
@rleungx rleungx requested review from JmPotato and removed request for disksing May 18, 2023 05:18
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.06 ⚠️

Comparison is base (e715cfc) 75.07% compared to head (54e0152) 75.02%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
- Coverage   75.07%   75.02%   -0.06%     
==========================================
  Files         410      410              
  Lines       41809    41809              
==========================================
- Hits        31389    31367      -22     
- Misses       7688     7699      +11     
- Partials     2732     2743      +11
Flag Coverage Δ
unittests 75.02% <33.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/metastorage/server/grpc_service.go 61.81% <ø> (ø)
pkg/mcs/metastorage/server/manager.go 100.00% <ø> (ø)
pkg/mcs/resourcemanager/server/apis/v1/api.go 81.35% <ø> (ø)
pkg/mcs/resourcemanager/server/config.go 70.51% <ø> (ø)
pkg/mcs/resourcemanager/server/grpc_service.go 64.44% <ø> (ø)
pkg/mcs/resourcemanager/server/install/install.go 100.00% <ø> (ø)
pkg/mcs/resourcemanager/server/manager.go 82.51% <ø> (ø)
pkg/mcs/resourcemanager/server/metrics.go 100.00% <ø> (ø)
pkg/mcs/resourcemanager/server/resource_group.go 70.32% <ø> (ø)
pkg/mcs/resourcemanager/server/server.go 52.99% <ø> (ø)
... and 11 more

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@nolouch
Copy link
Contributor

nolouch commented May 18, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 54e0152

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3fa9c36 into tikv:master May 18, 2023
@rleungx rleungx deleted the rename1 branch May 18, 2023 07:18
@rleungx rleungx mentioned this pull request May 26, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
*: unify import path format and rename the store meta functions (tikv…
c6f10a6 
…#6481)

ref tikv#5839, ref tikv#6418

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @nolouch @JmPotato