Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: put the scheduler related logic together #6491

Merged
merged 2 commits into from
May 23, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 19, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Part of #6418. Need to merge #6490 first.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • binshi-bing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 19, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and Yisaer May 19, 2023 07:30
@rleungx rleungx requested review from JmPotato and nolouch and removed request for disksing and Yisaer May 19, 2023 07:31
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 90.12% and project coverage change: +0.14 🎉

Comparison is base (e532925) 75.01% compared to head (0e8a15c) 75.15%.

❗ Current head 0e8a15c differs from pull request most recent head 801005e. Consider uploading reports for the commit 801005e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6491      +/-   ##
==========================================
+ Coverage   75.01%   75.15%   +0.14%     
==========================================
  Files         410      410              
  Lines       41894    41840      -54     
==========================================
+ Hits        31425    31444      +19     
+ Misses       7713     7661      -52     
+ Partials     2756     2735      -21     
Flag Coverage Δ
unittests 75.15% <90.12%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/keyspace/keyspace.go 61.75% <ø> (ø)
pkg/schedule/checker/checker_controller.go 80.00% <ø> (ø)
pkg/schedule/checker/joint_state_checker.go 57.89% <ø> (ø)
pkg/schedule/checker/learner_checker.go 72.72% <ø> (ø)
pkg/schedule/checker/merge_checker.go 70.99% <ø> (ø)
pkg/schedule/checker/priority_inspector.go 81.08% <ø> (ø)
pkg/schedule/checker/replica_checker.go 67.80% <ø> (ø)
pkg/schedule/checker/replica_strategy.go 86.00% <ø> (ø)
pkg/schedule/checker/rule_checker.go 82.41% <ø> (ø)
pkg/schedule/checker/split_checker.go 68.18% <ø> (ø)
... and 45 more

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
@rleungx
Copy link
Member Author

rleungx commented May 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3bbbe69

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit f7a4c63 into tikv:master May 23, 2023
@rleungx rleungx deleted the move-scheduler branch May 23, 2023 05:09
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839, ref tikv#6418, ref tikv#6490

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants