Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: update the mvcc db metrics of etcd #6506

Merged
merged 1 commit into from
May 24, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 24, 2023

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

metrics: update the mvcc db metrics of etcd
- distinguish between physical and logical

Check List

Tests

  • Unit test
  • Integration test
    image

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 24, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx May 24, 2023 09:28
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2023
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label May 24, 2023
@nolouch
Copy link
Contributor Author

nolouch commented May 24, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 5edac19

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit b45378a into tikv:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue
2 participants