Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: add scheduling microservice framework #6542

Merged
merged 3 commits into from
Jul 12, 2023
Merged

mcs: add scheduling microservice framework #6542

merged 3 commits into from
Jul 12, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 1, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Add a basic framework for scheduling service.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch June 1, 2023 06:54
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #6542 (ac93492) into master (c07c333) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6542      +/-   ##
==========================================
+ Coverage   74.17%   74.26%   +0.09%     
==========================================
  Files         412      412              
  Lines       43369    43370       +1     
==========================================
+ Hits        32167    32208      +41     
+ Misses       8316     8290      -26     
+ Partials     2886     2872      -14
Flag Coverage Δ
unittests 74.26% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from JmPotato and removed request for disksing June 2, 2023 04:20
@lhy1024 lhy1024 self-requested a review June 5, 2023 03:45
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 19, 2023
@rleungx rleungx force-pushed the scheduling-framework branch 2 times, most recently from 08e8978 to 40c39ce Compare June 19, 2023 06:52
lhy1024
lhy1024 reviewed Jul 4, 2023
View reviewed changes
pkg/mcs/scheduling/server/metrics.go Show resolved Hide resolved
pkg/mcs/scheduling/server/config_test.go Outdated
"github.com/stretchr/testify/require"
)

func TestAdjust(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to copy TestHotHistoryRegionConfig to here?

pkg/mcs/scheduling/server/config.go
)

// Config is the configuration for the resource manager.
type Config struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many configs. If we add a new config, we will have to add two in mcs server and pd server.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this part will be refactored later.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@rleungx rleungx mentioned this pull request Jul 11, 2023
Closed
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@rleungx
add scheduling microservice framework
55bce02 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
remove unnecessary configs
779a3f9 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@rleungx
make it simple
ac93492 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Jul 12, 2023

@lhy1024 @JmPotato I just revert the config-related change and do it later. Right now, it's quite simple. I just add a basic framework of microservices. PTAL.

@rleungx rleungx requested a review from lhy1024 July 12, 2023 07:33
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2023
@rleungx
Copy link
Member Author

rleungx commented Jul 12, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ac93492

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1ef1576 into tikv:master Jul 12, 2023
@rleungx rleungx deleted the scheduling-framework branch July 12, 2023 10:05
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
mcs: add scheduling microservice framework (tikv#6542)
ad27bab 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @JmPotato @lhy1024