Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSO Proxy: improve tso proxy reliability #6585
TSO Proxy: improve tso proxy reliability #6585
Changes from 1 commit
2501b87
2da4b0e
5d1ae54
b3ce3a3
7557e16
f3ca31c
75b9b49
623ec6d
70e5085
0bfd840
9a04e32
891c9d1
5bc03e0
b06b1eb
deafbbb
eb1d16b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to retry when meet this error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be retried anyway. Suppose this error happens, many forward streams will encounter this problem and report the error to the client. The client will retry to create tso stream again and send tso request, if tso server hasn't elected new primary, the NotLeaderErr will trigger force load again every 200 ms.