tools: support querying keyspace group by state #6706
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/L
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6706 +/- ##
==========================================
- Coverage 74.59% 74.53% -0.06%
==========================================
Files 416 416
Lines 43541 43584 +43
==========================================
+ Hits 32480 32487 +7
- Misses 8175 8205 +30
- Partials 2886 2892 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| re.NoError(failpoint.Enable("github.com/tikv/pd/pkg/keyspace/acceleratedAllocNodes", `return(true)`)) | ||
| re.NoError(failpoint.Enable("github.com/tikv/pd/server/delayStartServerLoop", `return(true)`)) | ||
| keyspaces := make([]string, 0) | ||
| // we test the case which exceed the default max txn ops limit in etcd, which is 128. |
| @@ -289,7 +289,7 @@ func TestMergeKeyspaceGroup(t *testing.T) { | |||
| for i := 0; i < 129; i++ { | |||
There was a problem hiding this comment.
forget. just noticed it's test.
| @@ -108,8 +108,29 @@ func GetKeyspaceGroups(c *gin.Context) { | |||
| c.AbortWithStatusJSON(http.StatusInternalServerError, err.Error()) | |||
| return | |||
| } | |||
| var kgs []*endpoint.KeyspaceGroup | |||
| state, set := c.GetQuery("state") | |||
There was a problem hiding this comment.
Is it case sensitive? Can we make it case insensitive?
| } | ||
| stateValue := "" | ||
| switch state { | ||
| case "merge", "split": |
There was a problem hiding this comment.
enable case insensitive?
ti-chi-bot
bot
added
status/LGT2
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 6f5790c
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5895 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ref tikv#5895 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ref tikv#5895 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5895.
What is changed and how does it work?
This PR adds a state flag to help query the keyspace group by state, which is useful for debugging the problem.
Check List
Tests
Release note