Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: move schedule plan to the right place #6769

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 6, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

The balance plan definition should be moved to the plan package.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 6, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and JmPotato July 6, 2023 08:24
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 6, 2023
@rleungx rleungx requested review from lhy1024 and CabinfeverB and removed request for disksing July 6, 2023 08:24
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #6769 (e0445f4) into master (fbedf3a) will decrease coverage by 0.05%.
The diff coverage is 87.69%.

❗ Current head e0445f4 differs from pull request most recent head 88462ff. Consider uploading reports for the commit 88462ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6769      +/-   ##
==========================================
- Coverage   74.17%   74.12%   -0.05%     
==========================================
  Files         411      411              
  Lines       43126    43126              
==========================================
- Hits        31988    31969      -19     
- Misses       8266     8279      +13     
- Partials     2872     2878       +6     
Flag Coverage Δ
unittests 74.12% <87.69%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2023
@JmPotato
Copy link
Member

JmPotato commented Jul 6, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e0445f4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c87782a into tikv:master Jul 6, 2023
@rleungx rleungx deleted the plan branch July 6, 2023 09:17
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants