schedule: refactor diagnostic manager #6771
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // Copyright 2022 TiKV Project Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package diagnostic | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "github.com/tikv/pd/pkg/errs" | ||
| "github.com/tikv/pd/pkg/schedule/schedulers" | ||
| "github.com/tikv/pd/server/config" | ||
| ) | ||
|
|
||
| // Manager is used to manage the diagnostic result of schedulers for now. | ||
| type Manager struct { | ||
| config *config.PersistOptions | ||
| schedulerController map[string]*schedulers.ScheduleController | ||
| } | ||
|
|
||
| // NewManager creates a new Manager. | ||
| func NewManager(schedulerController map[string]*schedulers.ScheduleController, config *config.PersistOptions) *Manager { | ||
| return &Manager{ | ||
| config: config, | ||
| schedulerController: schedulerController, | ||
| } | ||
| } | ||
|
|
||
| // GetDiagnosticResult gets the diagnostic result of the scheduler. | ||
| func (d *Manager) GetDiagnosticResult(name string) (*schedulers.DiagnosticResult, error) { | ||
| if !d.config.IsDiagnosticAllowed() { | ||
| return nil, errs.ErrDiagnosticDisabled | ||
| } | ||
|
|
||
| scheduler, isSchedulerExisted := d.schedulerController[name] | ||
|
There was a problem hiding this comment. I think there's going to be a data race. We handle schedulers in coordinator with lock, but here is no lock. There was a problem hiding this comment. Yes, add a lock, and I will remove it in the next PR. |
||
| if !isSchedulerExisted { | ||
| ts := uint64(time.Now().Unix()) | ||
| res := &schedulers.DiagnosticResult{Name: name, Timestamp: ts, Status: schedulers.Disabled} | ||
| return res, nil | ||
| } | ||
| var isDisabled bool | ||
| t := scheduler.Scheduler.GetType() | ||
| scheduleConfig := d.config.GetScheduleConfig() | ||
| for _, s := range scheduleConfig.Schedulers { | ||
| if t == s.Type { | ||
| isDisabled = s.Disable | ||
| break | ||
| } | ||
| } | ||
| if isDisabled { | ||
| ts := uint64(time.Now().Unix()) | ||
| res := &schedulers.DiagnosticResult{Name: name, Timestamp: ts, Status: schedulers.Disabled} | ||
| return res, nil | ||
| } | ||
|
|
||
| recorder := d.getSchedulerRecorder(name) | ||
| if recorder == nil { | ||
| return nil, errs.ErrSchedulerUndiagnosable.FastGenByArgs(name) | ||
| } | ||
| result := recorder.GetLastResult() | ||
| if result == nil { | ||
| return nil, errs.ErrNoDiagnosticResult.FastGenByArgs(name) | ||
| } | ||
| return result, nil | ||
| } | ||
|
|
||
| func (d *Manager) getSchedulerRecorder(name string) *schedulers.DiagnosticRecorder { | ||
| return d.schedulerController[name].GetDiagnosticRecorder() | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just a movement, maybe we don't need to change it?