Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule: use config interface for scheduler controller #6774

Merged
merged 4 commits into from
Jul 11, 2023
Merged

schedule: use config interface for scheduler controller #6774

merged 4 commits into from
Jul 11, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

It needs #6773 to merge first.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and JmPotato July 7, 2023 08:38
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #6774 (db5827d) into master (5759daf) will decrease coverage by 0.11%.
The diff coverage is 76.82%.

❗ Current head db5827d differs from pull request most recent head 9de69b2. Consider uploading reports for the commit 9de69b2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6774      +/-   ##
==========================================
- Coverage   74.29%   74.18%   -0.11%     
==========================================
  Files         413      413              
  Lines       43300    43171     -129     
==========================================
- Hits        32169    32026     -143     
- Misses       8267     8276       +9     
- Partials     2864     2869       +5
Flag Coverage Δ
unittests 74.18% <76.82%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
use config interface for scheduler controller
2a7a43e 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
address the comment
6401d33 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2023
@rleungx rleungx requested review from CabinfeverB and removed request for HunDunDM July 10, 2023 10:11
@rleungx rleungx mentioned this pull request Jul 11, 2023
Closed
@rleungx
address the comment
9de69b2 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx requested a review from HuSharp July 11, 2023 02:35
HuSharp
HuSharp approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 11, 2023
@rleungx
Copy link
Member Author

rleungx commented Jul 11, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9de69b2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 3cce629 into tikv:master Jul 11, 2023
19 checks passed
@rleungx rleungx deleted the use-interface branch July 11, 2023 03:17
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx @ti-chi-bot
schedule: use config interface for scheduler controller (tikv#6774)
5f72ae8 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

@HuSharp HuSharp HuSharp approved these changes

@CabinfeverB CabinfeverB Awaiting requested review from CabinfeverB

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @JmPotato @nolouch @HuSharp